Add links inside lightbox? about lightgallery HOT 21 CLOSED

Hi @erbertian

I have added link for the caption.You can enable this option by setting 'captionLink=true'.
Please have a look at this link http://jsfiddle.net/sachin377/qn656/

Ragards,
Sachin N

from lightgallery.

Hi Sachin N,

That's great and is exactly what I was looking for thank you very much. I hope you don't mind me asking, is it also possible to include a slide count too? So it displays 01, 02, 03 etc as the slide changes, or 1 of 5, 2 of 5, 3 of 5 etc.

Many thanks again.

from lightgallery.

hi @erbertian,
i've done it but have some issues with github. because of that i created a jsfiddle with my fork for you while its not possible for me to merge:
http://jsfiddle.net/549hG/

from lightgallery.

Hi tammo0,

Many thanks for that. I have added the revised js and relevant style. But the count isn't correct. I have two galleries set up as 'rel1' and 'rel2' one with a single video in (the counter says 1/4 for this) the other with 8 images in (the counter says 1/16, for this one)?

Thanks again.

from lightgallery.

Hi erbertian,
can you provide a jsfiddle of your setup?
Thanks,
tammo

from lightgallery.

Hi again,
@erbertian : http://jsfiddle.net/LyDAa/
this is how it works for me.

from lightgallery.

Hi again tammo0

Thanks for posting the fiddle. I have managed to recreate the issue: http://jsfiddle.net/LyDAa/4/
it seems that when the options: caption:true, desc:true, captionLink:true are used it is causing the issue? would there be a workaround for this? So I could still use the above options and retain the counter?

many thanks

from lightgallery.

Hi @erbertian
i fixed your issue. Look at line 363 and add a ">" to the selector between "slider" and "div":
https://github.com/tammo0/lightGallery/blob/master/light-gallery/js/lightGallery.js#L363

from lightgallery.

That's great tammo0. Worked a treat! Thank you very much.

Best wishes,
erbertian

from lightgallery.

Hi again,

sorry I have a further issue with the links inside the lightbox. All the slides are picking up the link from the last slide. So if slide 1 has the data-link 'www.google.com', slide 2 has the data-link 'www.google.com/2', and slide 3 has the data-link 'www.google.com/3'. When the lightbox is generated all the slides will show 'www.google.com/3' as the url.

If there is a way to resolve this I would appreciate it. Many thanks for the great work again.

from lightgallery.

Hi Erbertian,

It's working fine for me.
http://jsfiddle.net/sachin377/NDm5h/1/

from lightgallery.

Hi @tammo0,

I am not able to merge your pull request. your repository seems to be unavailable.

from lightgallery.

Hi Sachinchoolur

Thanks, It looks like it's when you use the option: mode:"fade" it causes the problem for me. If I take that option out, the links work fine, like in your jsfiddle above.

Is there a solution to this?

from lightgallery.

HI,

We can fix this issue by setting current slide z-index to 9.
please include these css code into your document.
#lightGallery-slider.fadeM.on .current {z-index: 9;}

Tammo's pull request is still pending ('for slide count'). so i am not able to upload updated css file.

Regards,
Sachin.

from lightgallery.

@sachinchoolur, see #12 - i think it should work now. regards, tammo

from lightgallery.

@tammo0, It is working now.

from lightgallery.

Hi Sachin,

thanks for the current slide z-index fix. It has improved it, but the first slide still has the last slides link, but if you click to the 2nd slide and then go back to the 1st again the link is then correct.

from lightgallery.

HI Erbertian,

Yesterday i couldn't test that properly. sorry for the inconvenience.
the issue has been fixed and uploaded. please do replace lightGallery.css
here is the updated fiddle http://jsfiddle.net/sachin377/NDm5h/2/

from lightgallery.

Hi Sachin,

you don't need to apologise. The new fix is now working as desired. Thank you again for your excellent support and work.

Best,
erbertian

from lightgallery.

Thanks

from lightgallery.

hi @erbertian , please open a new issue for every problem, bug or question you have.
when someone else is looking for a solution its easier for them to find it because it relates to the topic. Also for fixing bugs or writing features its better to have different issues you can relate to.

from lightgallery.