Spurious DOMExceptions / "Namespace Error" about dav HOT 7 CLOSED

From [email protected] on July 14, 2009 16:13:50:
Hi Toupeira,

Would you be able to supply the complete request body + headers for this?

It looks like a client is trying to make a propfind request with a property unknown
to SabreDAV (in a custom namespace).

I'm interested to see what this request is exactly..

Thanks!

from dav.

From [email protected] on July 14, 2009 17:23:17:
I'll try to capture it, but it will be difficult because I don't know who's doing it ;)

from dav.

From [email protected] on July 14, 2009 17:27:49:
Perhaps I can find stuff just based on looking at the actual code.

from dav.

From [email protected] on July 14, 2009 19:07:43:
Hold on, I changed the code so it now simply catches that exception, logs the request
body (using $this->httpRequest->getBody(true)) and headers ($_SERVER), and re-throws
the exception. Now I'll just have to wait... it seems it doesn't happen as often as I
first thought ;)

from dav.

From [email protected] on July 14, 2009 19:21:27:
Great! Even edge cases are very important for me :) I'm definitely aiming for a
utopian bug-free app :)

from dav.

From [email protected] on July 16, 2009 11:06:12:
The error didn't show up anymore, with 0.7 it came a dozen times a day so I suppose
you already fixed the bug in 0.8 ;)

Looking at the diff between 0.7 and 0.8 I found this change in
Sabre_DAV_Server#parseProps():

/* If there are no elements in here, we actually get 1 text node, this special case
is dedicated to netdrive */
if ($propNodeData->nodeType != XML_ELEMENT_NODE) continue;

So it seems NetDrive caused the DOMExceptions, and this code removes the offending nodes?

from dav.

From [email protected] on July 16, 2009 12:47:29:
Yes, I forgot about this bugfix. Netdrive sends a weird PROPFIND request, so we
needed to have a special clause to get around this.

Closing this bug

from dav.