Giter Club home page Giter Club logo

Comments (4)

sabertazimi avatar sabertazimi commented on June 10, 2024

Solution:

  1. Re-create app with [email protected] (bug-free version):
npx bod@latest create bod
  1. Or change createRoot to legacy ReactDOM.render.

from bod.

mescalito avatar mescalito commented on June 10, 2024

Hi @sabertazimi
I just wanted to let you know that the command "npx bod create bod" stated on the npm page (https://www.npmjs.com/package/cra-template-bod) is not working and the solution you have been working on for so long is not working out of the box.
Yes, I can fix the issue, but my question to you is: why deliver something that doesn't work out of the box?
I hope my point makes sense.
Thanks!

from bod.

sabertazimi avatar sabertazimi commented on June 10, 2024

If you run npx bod create bod failed, I think the reason is npx cache:

npx bod create bod # Will install [email protected], bug version
npx bod@latest create bod # Will install latest bod ([email protected], I released yesterday), bug free version

from bod.

sabertazimi avatar sabertazimi commented on June 10, 2024

When I released @sabertazimi/cra-template-typescript v5.8.1, @types/react-dom v17.0.14 contains client.d.ts.
So it passed E2E testing on GitHub CI.

But after that, @types/react-dom v17.0.15 removed client.d.ts (I don't know why React team puts breaking change in patch version).
As a result, E2E testing on GitHub CI failed.

Then I fixed it by updating @types/react-dom to v18, but I forgot release this change to npm.
After you find this issue, I released @sabertazimi/cra-template-typescript v5.9.0 to npm.

from bod.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.