Giter Club home page Giter Club logo

Comments (6)

saadmk11 avatar saadmk11 commented on May 24, 2024

Hi @bastelfreak, This action should run on a schedule event or a workflow_dispatch event.

Example:

# Controls when the action will run.
on:
  # can be used to run workflow manually
  workflow_dispatch:
  schedule:
    # Automatically run on every Sunday
    - cron:  '0 0 * * 0'

Does the token for actions/checkout@v2 actually needs the workflow scope?

I think the action should work without this.

The action is marked as successful, even when the push failed. I think that should be changed?

I need to update this behavior.

from github-actions-version-updater.

desecho avatar desecho commented on May 24, 2024

Does the token for actions/checkout@v2 actually needs the workflow scope?

I think the action should work without this.

If I add it to a repo without this, it fails to push a branch saying that the workflow permission is not there, however after I add it, run the workflow, then it succeeds, then I remove it from the workflow, run it again and it still works. Looks like a bug of some kind. I am not sure what is going on there.

from github-actions-version-updater.

saadmk11 avatar saadmk11 commented on May 24, 2024

If I add it to a repo without this, it fails to push a branch saying that the workflow permission is not there, however after I add it, run the workflow, then it succeeds, then I remove it from the workflow, run it again and it still works. Looks like a bug of some kind. I am not sure what is going on there.

Hi @desecho, Thanks for the bug report. 👍 I have not worked on this for sometime. I will check it out and try to reproduce it when I get some time.

from github-actions-version-updater.

vladislav-tkach avatar vladislav-tkach commented on May 24, 2024

Does the token for actions/checkout@v2 actually needs the workflow scope?

It seems that it does need a workflow-scoped token. Otherwise, I get an error when the version updater action tries to push a new branch. Not sure why is that but I found the solution here: https://github.com/orgs/community/discussions/27072

from github-actions-version-updater.

saadmk11 avatar saadmk11 commented on May 24, 2024

The action is marked as successful, even when the push failed. I think that should be changed?

I need to update this behavior.

Fixed in #17

from github-actions-version-updater.

saadmk11 avatar saadmk11 commented on May 24, 2024

Does the token for actions/checkout@v2 actually needs the workflow scope?

It seems that it does need a workflow-scoped token. Otherwise, I get an error when the version updater action tries to push a new branch. Not sure why is that but I found the solution here: https://github.com/orgs/community/discussions/27072

GitHub Actions Log when PAT without workflow scope is used:

! [remote rejected] gh-actions-update-1665821908 -> gh-actions-update-1665821908 (refusing to allow a Personal Access Token to create or update workflow `.github/workflows/new.yaml` without `workflow` scope)

Does the token for actions/checkout@v2 actually needs the workflow scope?

I think the action should work without this.

If I add it to a repo without this, it fails to push a branch saying that the workflow permission is not there, however after I add it, run the workflow, then it succeeds, then I remove it from the workflow, run it again and it still works. Looks like a bug of some kind. I am not sure what is going on there.

I can confirm this. Not sure whats going on here. Happens after changing token with workflow scope to token without workflow scope.

from github-actions-version-updater.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.