Comments (6)
This example, these four lines of code break my whole singleton-based multilevel architectural infrastructure, this little fly
from dom-expressions.
I tried in REPL no err.
Maybe I could refresh my app somehow?
Reinstall dependencies?
from dom-expressions.
The REPL might not be in dev mode. The error is correct. The problem is browsers automatically correct poorly formed HTML. We build the DOM using template cloning so we are at the mercy of how they "correct" our templates. In your example every browser adds a <tbody>
around the <tr>
s. Manually adding it fixes the problem. Ive considered adding code to automatically add the <tbody>
just there are a ton of these scenarios. I haven't found a library that can check for this at compile time as of yet. Would love to smooth this out.
By the way, if the table had dynamic parts it would break in production, because the walks that add effect bindings would be broken.
from dom-expressions.
lol, when i saw this issue title i immediately thought, "Bet it's implicit <tbody>
" :D
i have a devmode warning for this in domvm: https://github.com/domvm/domvm/blob/master/src/view/addons/devmode.js#L58
from dom-expressions.
Ryan, God bless your golden arms and big beautiful heart!
I just wanna say thank you to the whole sold.js team! We're gone from this dirty bloated react and massive-ass slow-baby angular, now we can keep our code vanilla. The issue gone.
from dom-expressions.
No problem. Thanks for the kind words.
from dom-expressions.
Related Issues (20)
- [html] top level <style> causes TypeError: Cannot read properties of undefined (reading 'firstChild')
- [html] empty html template causes TypeError: Cannot read properties of undefined (reading 'name')
- `o[1] is not a function`
- There is no definition of `media` property in interface `MetaHTMLAttributes`
- Bug in generic types for universal render target? HOT 5
- Type definitions of `classList` are wrong HOT 8
- Treat `inert` as a boolean attribute
- Support combining tag classes and the class property in hyper dom expressions HOT 1
- Don't consider namespace imports to be dynamic expression HOT 3
- Emit var instead of const for generated element references HOT 7
- Add ability not to treat every tag with `-` in name as web component HOT 4
- `this` inside arrow function is incorrect after Solid transform HOT 3
- `<this.Foo />` doesn't work HOT 2
- Supporting iterable collections HOT 4
- Question: Possible to use third-party component libraries with Tagged Template Literals? HOT 6
- Template generation template literal escape problem
- bug: Compilation from JSX style attribute to ternary results in functions getting called twice HOT 1
- JSX attribute types HOT 2
- Option for preserving whitespace within JSXChildren HOT 1
- Fragment loses reactivity when using HDE HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dom-expressions.