Giter Club home page Giter Club logo

Comments (6)

 avatar commented on August 20, 2024

This example, these four lines of code break my whole singleton-based multilevel architectural infrastructure, this little fly

from dom-expressions.

 avatar commented on August 20, 2024

I tried in REPL no err.
Maybe I could refresh my app somehow?
Reinstall dependencies?

from dom-expressions.

ryansolid avatar ryansolid commented on August 20, 2024

The REPL might not be in dev mode. The error is correct. The problem is browsers automatically correct poorly formed HTML. We build the DOM using template cloning so we are at the mercy of how they "correct" our templates. In your example every browser adds a <tbody> around the <tr>s. Manually adding it fixes the problem. Ive considered adding code to automatically add the <tbody> just there are a ton of these scenarios. I haven't found a library that can check for this at compile time as of yet. Would love to smooth this out.

By the way, if the table had dynamic parts it would break in production, because the walks that add effect bindings would be broken.

from dom-expressions.

leeoniya avatar leeoniya commented on August 20, 2024

lol, when i saw this issue title i immediately thought, "Bet it's implicit <tbody>" :D

i have a devmode warning for this in domvm: https://github.com/domvm/domvm/blob/master/src/view/addons/devmode.js#L58

from dom-expressions.

 avatar commented on August 20, 2024

Ryan, God bless your golden arms and big beautiful heart!

I just wanna say thank you to the whole sold.js team! We're gone from this dirty bloated react and massive-ass slow-baby angular, now we can keep our code vanilla. The issue gone.

from dom-expressions.

ryansolid avatar ryansolid commented on August 20, 2024

No problem. Thanks for the kind words.

from dom-expressions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.