Giter Club home page Giter Club logo

Comments (4)

trusktr avatar trusktr commented on August 20, 2024

Hmmm. I do see "dom-expressions": "^0.19.10", in devDependencies. 🤔

from dom-expressions.

trusktr avatar trusktr commented on August 20, 2024

Seems like that's the issue: because lit-dom-expressions types depend on dom-expression types, then dom-expressions needs to be a dependency instead of devDependency.

Strange, I know, but otherwise TS users get the error. I think it's OK to have an extra dependency installed on the developer's file system just for the types.

This is discussed somewhere in TypeScript issues. Basically dom-expressions can be left as a devDependency only if the lit-dom-expressions does not re-export or need to expose any of dom-expressions types.

For example, if you export something like

import type {Foo} from 'some-package'

export class Bar extends Foo {...}

then some-package needs to be a dependency because otherwise Foo will not be visible for the end user, but Foo needs to be visible for the end user in order for the Bar class to typed properly.

from dom-expressions.

trusktr avatar trusktr commented on August 20, 2024

PR: #26

from dom-expressions.

ryansolid avatar ryansolid commented on August 20, 2024

This will be resolved in v0.20.0.

from dom-expressions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.