Variable - Use meaningful and pronounceable variable names - yearMonthDay is Not meaningful about clean-code-javascript HOT 4 CLOSED

Hey Chen!

True, those are more meaningful than yearMonthDay. That's only the case if those actually match up to a current instance of a moment object. What's always valid, and perhaps more meaningful, is todayYearMonthDay. It's a little verbose, but it's very clear. Maybe we can do better though. On Pg. 50, Clean Code gives a much better example that we can probably go to for JavaScript, excuse the lack of formatting:

Bad

public List<int[]> getThem() {
List<int[]> list1 = new ArrayList<int[]>(); for (int[] x : theList)
if (x[0] == 4) list1.add(x);
return list1; }

Good

public List<Cell> getFlaggedCells() {
List<Cell> flaggedCells = new ArrayList<Cell>(); for (Cell cell : gameBoard)
if (cell.isFlagged()) flaggedCells.add(cell);
return flaggedCells; }

from clean-code-javascript.

Mmm so maybe currentDate, todayDate its a bit more clear and less verbose. Regard to the flagged cell i agree :-)

from clean-code-javascript.

Cool, I've changed it to this for now! b1b37eb

from clean-code-javascript.

This is a huge nitpick... in my opinion, currentDate sounds like the name of a variable that holds a moment or Date object. It doesn't give any indication that it's a formatted date string. I would expect currentDate to just be const currentDate = moment().

I think the example could be improved by instead doing:

const d = moment(); // bad
const currentDate = moment(); // good

Ideally though, I think it would be even better to come up with an example that doesn't depend on a js library.

from clean-code-javascript.