created fo4dds ba2s are invalid about bsa HOT 16 CLOSED

I'm not sure it is enough, but on my small sample, the fix was to change BitsPerPixel. Dividing it by 4 fixed the issue

from bsa.

I've also noticed bsarch does not have Flags and BitsPerPixel. Instead, it has cubemaps:

https://github.com/TES5Edit/TES5Edit/blob/dev/Tools/BSArchive/wbBSArchive.pas#L278

from bsa.

Dividing BitsPerPixel per 4 is not a good solution. But I am still pretty confident the bug comes from this part

from bsa.

The problem might be more important than expected. rsm-bsa does not produce the same header as archive2 with the linked file

bsarch gets it right, so looking at the code might be helpful

test.zip

from bsa.

What are the permissions on this file?

from bsa.

I see what the issue is, beth does a bunch of stupid stuff to calculate chunk size and bits per pixel

from bsa.

Fixed by 84c18fc, but it still needs tests to guard against regressions, such as textures with cubemaps. The texture provided here is also a good sample, since it found a bug in how textures were chunked, but it depends on the licensing.

from bsa.

The licensing does not allow it, but the author is active. I've asked for permission and will keep you informed

from bsa.

Can confirm the fix appears to be working. The archive produced by rsm-bsa are still different, but I suppose it's only the file order that changes

from bsa.

Already 2 months? Time flies
So, I've found another mod to reproduce the bug, and it has open permissions. https://www.nexusmods.com/skyrim/mods/95466?
I tried with the whole mod, but mushroom01_e is marked as "XBOXDDS"

from bsa.

These files don't manage to add test coverage for the newly discovered chunking strategy for dds files, but they did manage to uncover a new bug. I believe cubemaps are excluded from chunking, which is what the flag in the archive file header is for.

from bsa.

Added more coverage and another fix in e96e4ab

from bsa.

So, do you know the consequences of this bug? I didn't get any report, so I assume it doesn't cause CTD?

from bsa.

texture.zip

So, here's the texture that originally found the issue. I manually blacked it out. Pretty sure we can't get permission issue after that

from bsa.

Added coverage for chunking in 63c01e2

from bsa.

I don't know if there's actually an issue with chunking archives incorrectly, but it's best to conform to whatever Archive2.exe produces.

from bsa.