Comments (9)
This project isn't super active - feel free to make a PR with the code I suggested above:
public private(set) var disposeBag = DisposeBag()
from rxviewmodel.
Hey @calvingit thanks for reporting.
Would you mind telling me which version of Xcode
and also which version of RxViewModel
are you trying to use?
Thanks
from rxviewmodel.
Xcode: 8.3.3
RxViewModel: 5.0.0
from rxviewmodel.
Thanks; I'll take a look later today and hopefully I'll be able to release a new version addressing this issue.
Thanks for reporting.
from rxviewmodel.
@calvingit Could you change
RxViewModel.swift:L25 to
public private(set) var disposeBag = DisposeBag()
And confirm if that helps your issue ?
from rxviewmodel.
No problem if the disposeBag
is public
from rxviewmodel.
Guys, disposeBag is still not public, every-time i update pods i have to edit it to be public and I think this class is supposed to be superclass. Would you mind changing please? I can make PR buts its so tiny change that its a waste of time :)
Thanks for your time
from rxviewmodel.
Check PR #63
from rxviewmodel.
from rxviewmodel.
Related Issues (20)
- Better Carthage support HOT 1
- Fix broken CI HOT 1
- Fix Codecov.io
- Update to rxswift & rxcocoa 2.2? HOT 2
- Fix the CI HOT 1
- RxViewModel is depending on an old version of RxCocoa HOT 3
- Retain cycle HOT 1
- throttleSignalWhileInactive is sending events while the receiver is inactive HOT 7
- Carthage minimum deployment target 8.3 HOT 2
- Add test for Carthage builds
- Update Swift 3 HOT 6
- Carthage fails to build HOT 2
- Change CI provider HOT 3
- You should make RxViewModel class "open" HOT 3
- Update podspec on cocoapods repo HOT 7
- Can't use RxSwift 3.6.1 HOT 4
- README for non-ReactiveCocoa devs? HOT 1
- Update with RXSwift 4
- Unable to run the demo
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rxviewmodel.