Giter Club home page Giter Club logo

Comments (9)

freak4pc avatar freak4pc commented on September 27, 2024 1

This project isn't super active - feel free to make a PR with the code I suggested above:

public private(set) var disposeBag = DisposeBag()

from rxviewmodel.

esttorhe avatar esttorhe commented on September 27, 2024

Hey @calvingit thanks for reporting.

Would you mind telling me which version of Xcode and also which version of RxViewModel are you trying to use?

Thanks

from rxviewmodel.

calvingit avatar calvingit commented on September 27, 2024

Xcode: 8.3.3
RxViewModel: 5.0.0

from rxviewmodel.

esttorhe avatar esttorhe commented on September 27, 2024

Thanks; I'll take a look later today and hopefully I'll be able to release a new version addressing this issue.

Thanks for reporting.

from rxviewmodel.

freak4pc avatar freak4pc commented on September 27, 2024

@calvingit Could you change

RxViewModel.swift:L25 to
public private(set) var disposeBag = DisposeBag()

And confirm if that helps your issue ?

from rxviewmodel.

calvingit avatar calvingit commented on September 27, 2024

No problem if the disposeBag is public

from rxviewmodel.

beretis avatar beretis commented on September 27, 2024

Guys, disposeBag is still not public, every-time i update pods i have to edit it to be public and I think this class is supposed to be superclass. Would you mind changing please? I can make PR buts its so tiny change that its a waste of time :)
Thanks for your time

from rxviewmodel.

calvingit avatar calvingit commented on September 27, 2024

Check PR #63

from rxviewmodel.

esttorhe avatar esttorhe commented on September 27, 2024

Fixed with #63 and adb7865

from rxviewmodel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.