collectionView(_:layout:referenceSizeForHeaderInSection:) about rxdatasources HOT 6 CLOSED

Hi @serluca ,

I'm not sure what is the suggestion here.

collectionView(_:layout:referenceSizeForHeaderInSection:) is part of delegate and not data source, so we can't implement this on data source.

I think that RxDelegate should report collectionView(_:layout:referenceSizeForHeaderInSection:) wasn't implemented in case delegate isn't implementing it because it has void return type, so little confused it returns (0, 0). Why do you think it does?

What we could theoretically do is for data source to also implement delegate methods, and then create an extension rx_itemsWithDataSourceAndDelegate.

from rxdatasources.

Hi @kzaher,

I know is not part of the data source (I don't know why apple did that, I think it should), the problem here is not RxDelegate is the default UICollectionViewFlowLayoutDelegate that returns CGSizeZero.

I like what you are suggesting here:

What we could theoretically do is for data source to also implement delegate methods, and then create an extension rx_itemsWithDataSourceAndDelegate.

It would be very cool

from rxdatasources.

Hi @serluca ,

would

What we could theoretically do is for data source to also implement delegate methods, and then create an extension rx_itemsWithDataSourceAndDelegate.

even help in this case. According to this, it sounds like not.

from rxdatasources.

Hi @kzaher

What I'm suggesting here is to have a method that looks like

dataSource.supplementaryViewFactory = { (dataSource, collectionView, kind, indexPath) in
}

But for the delegate method collectionView(_:layout:referenceSizeForHeaderInSection:) something like

dataSourceAndDelegate.referenceSizeForHeaderFactory = { { (dataSource, collectionView, section)
}

Having this method, we can customize the header size and keep the same syntax that we use for the dataSource.

Right now my code looks like this (and I think is ugly):

class MyClass {
    func skinCollectionView() {
        dataSource.supplementaryViewFactory = { (dataSource, collectionView, kind, indexPath) in
            ...
        }
    }   
}

extension MyClass : UICollectionViewDelegateFlowLayout {

    func collectionView(collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, referenceSizeForHeaderInSection section: Int) -> CGSize {
        ....
        return Size
    }
}

from rxdatasources.

Can you make a PR?

from rxdatasources.

I'll try :)

from rxdatasources.