AssetFilterManager as AbstractPluginManager about assetmanager HOT 5 CLOSED

May I ask you why? (Would you mind explaining why that would be better)

from assetmanager.

Yes, of course :)

Here is why I think it may be useful:

• it a common way in ZF2 to use AbstractPluginManager for something which may act as container for extension, plugin or helper.
• ZF2 users know how to use PluginManager's: they know how to add items in it and work with them;
• AssetFilterManager must allow: add filters and sometimes this may be a relatively complex task, because filter may have dependencies and some configuration before use. PluginManager natively allow register services as factories or callbacks. In the travail case it allow invocable as filters;
• there is no much sense to keep AssetManger Filters in global (application) ServiceManager, because they likely not be used in application scope. Instead filters should be placed in some isolated container (like controllers or view helpers), PluginManager allow this;
• during creation of the filters access to application ServiceManager may be required. PluginManager also allow this;
• all filters must be implement specific interface PluginManager allow validate instances;
• its quite easy to use PluginManager for this purpose (I mean not much code needs to be changed).

from assetmanager.

@alexshelkov I like the idea, it is a valuable addition :) I don't really understand the reason for not having filters in the global service manager though, that would just be a limitation.
A simple plugin manager with the main service manager as peering SM would be fine.

from assetmanager.

I'm terribly sorry but I did not understand a lot of what you said. I don't want to sound insulting but your English is not that good and it's difficult for me to understand. But from the parts that I did get, I'd like to point you to Assetic (which is what I'm using). So I'm not registering filters, I'm fetching them on demand. I already support services, too. Perhaps a PR would make things clearer on my end. Thank you for your involvement :)

from assetmanager.

@alexshelkov looking at https://github.com/RWOverdijk/AssetManager/wiki/Filters and talking with @RWOverdijk I noticed that filters can already be services... What's the difference now (except being able to validate the filters in a plugin manager)?

from assetmanager.