Giter Club home page Giter Club logo

Comments (6)

konflictue avatar konflictue commented on May 31, 2024 1

Modify the above file
return self.decodeBytes(tokens).decode('utf-8','ignore')
lost character λ…•

@cgisky1980 You can also try the 'replace' mode for errors here, which had better chances for producing all characters properly when using the world models of rwkv.

from rwkv.cpp.

saharNooby avatar saharNooby commented on May 31, 2024

by model rwkv world fp16 is correct

Do you mean that the same code works correctly when using FP16 model?

from rwkv.cpp.

cgisky1980 avatar cgisky1980 commented on May 31, 2024

by model rwkv world fp16 is correct

Do you mean that the same code works correctly when using FP16 model?
yes

I mean, models without quantization don't have this problem

from rwkv.cpp.

saharNooby avatar saharNooby commented on May 31, 2024

Then I think this issue actually points at 2 separate problems:

  1. quantized model produces less correct text that non-quantized model
  2. UnicodeDecodeError error is thrown

For 1, there is no real solution. Quantization reduces quality, it is expected, since information is cut from the model to make it smaller.

2 is an actual bug that can be fixed. I'll put it into my backlog, but anyone can take it.

from rwkv.cpp.

cgisky1980 avatar cgisky1980 commented on May 31, 2024

Then I think this issue actually points at 2 separate problems:

  1. quantized model produces less correct text that non-quantized model
  2. UnicodeDecodeError error is thrown

For 1, there is no real solution. Quantization reduces quality, it is expected, since information is cut from the model to make it smaller.

2 is an actual bug that can be fixed. I'll put it into my backlog, but anyone can take it.

Because this issue is 100% reproducible in models 3B and 7B, I don't think it's a problem of accuracy loss

ps. https:github.com//issues/19 this is the good first issue. LOL

from rwkv.cpp.

cgisky1980 avatar cgisky1980 commented on May 31, 2024

Modify the above file
return self.decodeBytes(tokens).decode('utf-8','ignore')
lost character λ…•

@cgisky1980 You can also try the 'replace' mode for errors here, which had better chances for producing all characters properly when using the world models of rwkv.

yes,it works

from rwkv.cpp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.