Giter Club home page Giter Club logo

Comments (6)

rvesse avatar rvesse commented on August 12, 2024

Turns out we can't use Annotation as the general type of a restriction but we can use Class<? extends Annotation> so the definition will need to look something like the following:

@Option(name = "--example", arity = 2)
@PartialRestriction(index = 0, restriction = NotBlank.class)
@NotBlank
private List<String> examples;

And we'll need special logic in MetadataLoader to load the list of @PartialRestriction and modify generated restrictions as necessary

I have run into one bug which is that if you want to partially apply a postValidate() based restriction this does not work because postValidate() assumes the ability to see the full state. So we need to change that to finalValidate() method and introduce a new postValidate() method that sees the strongly typed value at the point at which it is introduced

from airline.

rvesse avatar rvesse commented on August 12, 2024

More thoughts:

  • Will need an @Partials to cope with the case where you want to define multiple @Partial on a single field
  • Need to work out how to implement HelpHint for PartialRestriction in a sane manner
  • MetadataLoader needs to obtain and act upon the @Partial/@Partials that are present

from airline.

rvesse avatar rvesse commented on August 12, 2024

Will also need to document Migration because some of these changes are breaking

Finally it would be ideal if restrictions that make no sense as @Partial error ASAP

from airline.

rvesse avatar rvesse commented on August 12, 2024

Also it would be nice if the current means of enforcing restrictions is moved from the parsers into ParseState so people can't write parsers that don't enforce the restrictions and we don't have to duplicate code so much

from airline.

rvesse avatar rvesse commented on August 12, 2024

Everything but HelpHint support is done

from airline.

rvesse avatar rvesse commented on August 12, 2024

Added HelpHint support so closing this now

from airline.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.