Giter Club home page Giter Club logo

Comments (14)

rverchere avatar rverchere commented on July 17, 2024

Hi,

I'm thinking about it, thanks for the inputs, I'll read them carefully.
My main concern is about login/passwords used to connect to each esxi/vcenter.

from vmware_exporter.

wtip avatar wtip commented on July 17, 2024

for my particular use case all of the endpoints I would want to monitor with a single exporter use the same username and password so I would be fine with leaving that part in a static config file.

from vmware_exporter.

ipsecguy avatar ipsecguy commented on July 17, 2024

Hi,

I agree with wtip, would be a cool addition.

Regarding the passwords I think they should be placed in the config file, basically replicating the section format that is used in the current implementation for multiple endpoints. The metrics collection would then reference one of the multiple configurations by name, leaving the credentials hidden in the exporter's config.

Andreas

from vmware_exporter.

is4it-lab avatar is4it-lab commented on July 17, 2024

Hi,

this would be a great extention.
Another thing in this context:
It would be great to have more information for filtering in the counters.
for example the ESX host to the VM or the cluster to the host

for example VM fom now:
{instance="localhost:9272",job="vmware",vm_name="vcenter-psc01"}
to
{instance="localhost:9272",job="vmware",host="esx1",vm_name="vcenter-psc01"}

or host
{host_name="esx1",instance="localhost:9272",job="vmware"}
to
{host_name="esx1",instance="localhost:9272",job="vmware",cluster="Lab-Cluster",datacenter="MUC"}

Robert

from vmware_exporter.

ipsecguy avatar ipsecguy commented on July 17, 2024

Just tested the multi_endpoint branch, seems to work. I will put in test.

Now a parameter "target" (similar to SNMP) could be used to reference a section in the config file, even though it is quite clumsy in the prometheus config. Should be similar to:

- job_name: 'vmware'
    scrape_interval:     60s
    target_groups:
      - targets:
        - lab-cluster # reference section in vmware_exporter.yml
        - test-esxi-host # references another section
    relabel_configs:
      - source_labels: [__address__]
        regex: (.*?)(:80)?
        target_label: __param_target
        replacement: ${1}
      - source_labels: [__param_target]
        regex: (.*?)(:80)?
        target_label: instance
        replacement: ${1}
      - source_labels: []
        regex: .*
        target_label: __address__
        replacement: 127.0.0.1:9272  # vmware exporter.

from vmware_exporter.

rverchere avatar rverchere commented on July 17, 2024

@ipsecguy, I have just started finding doc on how to manage multi endpoints, it is not implemented so far in the multi_endpoint branch;)
The only difference now is that it makes a connect/disconnect for each request.

from vmware_exporter.

ipsecguy avatar ipsecguy commented on July 17, 2024

Yes, I know, I read the code. It was more to see whether there are any side effects with connect/disconnect at each scrape. But I just saw your update, I will test later this evening.

from vmware_exporter.

rverchere avatar rverchere commented on July 17, 2024

This is mostly done, waiting for your feedbacks before closing it.

from vmware_exporter.

is4it-lab avatar is4it-lab commented on July 17, 2024

Hi,

I don't understand the part with file_sd_configs
can you show an example of /etc/prometheus/esx.yml ?

Robert

from vmware_exporter.

rverchere avatar rverchere commented on July 17, 2024

@is4it-lab, it's a different way to list targets ( see file_sd_config ):

- targets:
  - 'esx1.company.com'
  - 'esx2.company.com'

from vmware_exporter.

ipsecguy avatar ipsecguy commented on July 17, 2024

Hi,

I am now able to scrape multiple ESXi host. I am not using a "default" section (all my hosts are configured explicitly). Deleting the default section seems to stop it working, putting dummy account data seems breaks things, the metrics URL is then empty.

from vmware_exporter.

rverchere avatar rverchere commented on July 17, 2024

@ipsecguy, for now you must have a default section.

from vmware_exporter.

wtip avatar wtip commented on July 17, 2024

@rverchere Thank you for implementing this. I just got around to trying this out today. I've got it scraping 4 hosts at the moment.

from vmware_exporter.

rverchere avatar rverchere commented on July 17, 2024

Works for me for weeks now, I can close the issue.

from vmware_exporter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.