Giter Club home page Giter Club logo

Comments (2)

tvincent2 avatar tvincent2 commented on August 24, 2024

Hi!

I think a good first step would be to report the lines where lexical errors occur. I will try to implement that by adding the line number in the Lexer struct in lexer.rs so it can be used in errors. Then I will also add it to the Span struct in lexer.rs so it can be used later during the parsing.

What do you think about it?

from pris.

ruuda avatar ruuda commented on August 24, 2024

Span is sufficient to track source code locations, it can be translated back into line numbers, and the lexer already reports errors in that way. The challenge is to add spans to AST nodes and keep them around, without them getting in the way everywhere. The first thing that comes to mind is to add a Span to every AST node, but that means having to update every match, so it is very invasive, and it also pollutes the matches with this span field that you usually don’t care about. I am not aware of an elegant solution, but I also haven’t researched or thought about this extensively yet.

from pris.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.