Giter Club home page Giter Club logo

Comments (5)

DCjanus avatar DCjanus commented on May 25, 2024 1

published

from rss.

SSheldon avatar SSheldon commented on May 25, 2024

When the next version of rss is published, I'd also love to see a new version of atom so that both crates are off of failure and have the builders feature. But I can file a separate issue on atom them :)

from rss.

DCjanus avatar DCjanus commented on May 25, 2024

I'm not sure which version should be, 2.0.0 or 1.9.0? @rust-syndication/publish

from rss.

SSheldon avatar SSheldon commented on May 25, 2024

Here's my assessment if it's useful:

  • the crate was updated to the 2018 edition of rust, which might raise the minimum supported rust version? I'm not aware of this crate advertising a msrv, and I don't think there's a consensus that this must be considered a breaking change
  • the value of Error::Xml was changed to no longer be a failure::Compat, but it's still a type that implements Error, so realistically I doubt this is likely to break real world code. This type has been changed in the past without requiring a major version bump.
  • ITunesCategory::subcategory no longer returns a reference to a Box
  • quick-xml and url were updated, but they aren't really public facing, except their error types?

To me, the biggest thing to consider there seems to be ITunesCategory::subcategory, but even that doesn't seem worth a new major release. So I think a 1.9.0 is justifiable.

from rss.

DCjanus avatar DCjanus commented on May 25, 2024

1.9.0 sounds good to me, I will release a new version in two days, feel free to show your opinion.

from rss.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.