Filtering posts (items) out of a Channel about rss HOT 4 CLOSED

Seems like we could add an fn items_mut(&mut self) -> &mut [Item] on a Channel to complement the fn item(&self) -> &[Item] method.

from rss.

@frewsxcv To be clear, I'm very grateful this library exists so that I don't have to go through the schlep of making a multi-RSS version compliant library myself!

What you describe is a solution but is there a strong motivation for making it impossible to work with the data itself? There's any number of things someone might want to do with channel metadata or other bits and the library's universally private fields means someone has to file an issue or a PR every time they need a new getter or setter. That seems a bit byzantine.

from rss.

Resolved in #62

What you describe is a solution but is there a strong motivation for making it impossible to work with the data itself? There's any number of things someone might want to do with channel metadata or other bits and the library's universally private fields means someone has to file an issue or a PR every time they need a new getter or setter. That seems a bit byzantine.

In my opinion, having all the struct fields be exposed is a valid design decision here (and one I had originally for this crate). I also think the current design decision of having these getters/setters is also a valid design. I think having both exposed struct fields with the getters/setters is a bit redundant thought.

One possible advantage with the current design is we also get to specify Into<..> for all the parameters in the setters, which improve ergonomics a bit. Some people like this more than others; I'm pretty neutral about it personally.

In all, I don't feel strongly about which design is better, but at this point, I'm in favor of keeping the current design to reduce churn for dependent projects. If there's anything we/I can do to help facilitate your use case of this crate, let me know!

from rss.

Thank you for the considered reply and the patch to support taking mutable slices of channel contents!

from rss.