Comments (4)
frewsxcv
commented on May 25, 2024
I feel like this sort of comment should have gone into #35 when we did the restructuring. I don't have any strong feelings about this. I'm not opposed to just adding setters on all the non-builder structures. I'm not personally worried about the duplication of fields between the builders and non-builders. I'd wait for @PhnxRbrn to chime in before making any changes
from rss.
jameshurst
commented on May 25, 2024
Yeah, I agree this is probably something I should have thought of before we merged #35. After thinking about this issue I think the easiest solution would be to simply add a constructor to each of the builder methods that takes a non-builder object.
from rss.
chrisppy
commented on May 25, 2024
@jameshurst Personally I would prefer to keep the builder methods and add a constructor to consume the non-builder object as you mentioned in your last comment.
from rss.
jameshurst
commented on May 25, 2024
@PhnxRbrn 👍 that's what I was leaning towards after thinking about it for a while.
from rss.
Related Issues (20)
- Automatically add the content namespace to a channel when an item makes use of <content:encoded> (or document the requirement) HOT 1
- Allow taking a chrono::DateTime when setting e.g. pub_date, last_build_date, etc.
- Add dc:date item field to pubDate field HOT 4
- valid RSS feed can not be parsed HOT 1
- Allow choice between `write_cdata_element` and `write_text_element` HOT 5
- Err when reading/writing/reading a channel
- Track changes
- All build methods returning String instead of Error HOT 3
- Make ToXml public HOT 4
- wasm build HOT 2
- Add support for the podcast namespace
- Getters and setters for new extensions HOT 2
- update `quick_xml` dependency HOT 2
- Support CDATA or values without escaping when writing Extension.value HOT 4
- Invalid RSS feed when having 0 items in a podcast HOT 6
- Failed to build HOT 1
- Extensions not recognized when namespaces are declared inline HOT 1
- Podcast rss feed returns EOF with rust-syndication crate HOT 8
- iTunes extension not working while the extensions map does contain the respective information HOT 8
- Encode & and < with hex codes HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rss.