Comments (4)
phip1611
commented on September 21, 2024
Good catch!
For reference: https://uefi.org/specs/UEFI/2.10/12_Protocols_Console_Support.html#efi-graphics-output-protocol-querymode
from uefi-rs.
phip1611
commented on September 21, 2024
Hm, I don't see how we can easily fix this without having access to the boot services. Probably, this is the point where we should consider #905, i.e., having the boot services stored in a global static.
What do you think, @nicholasbishop ?
I've set up a PR that comes with a breaking change:
#969
@JarlEvanson Did you spot this by looking at the code or by with some nice debugging tooling? I'm curious
from uefi-rs.
JarlEvanson
commented on September 21, 2024
I was looking at the specification and noticed that it returned a callee allocated buffer, but the uefi-rs implementation didn't take BootServices to deallocate it.
from uefi-rs.
nicholasbishop
commented on September 21, 2024
Should be fixed now with Philipp's PR merged. Thanks again for filing this issue :)
Re comment 3, added a note about this to #893 (the "add a global table pointer" issue).
from uefi-rs.
Related Issues (20)
- Example application fails to build with "could not find `helpers` in `uefi`" HOT 3
- `uefi::helpers` not found / Rust UEFI Book out of sync HOT 2
- Can not write file HOT 2
- No graphics HOT 2
- Set default features for uefi crate
- Use `cargo xtask fmt --check` in CI
- After 1.83 is released: bump MSRV and un-gate error_in_core impls
- make MemoryMap own its buffer (Vec) HOT 2
- CI failing due to dead_code warnings on nightly HOT 2
- Change the book to build from the latest tag instead of the latest commit on main HOT 1
- Need help for ACPI table, rsdt and xsdt entries are aberrant HOT 3
- Just a question about how I can exit boot services correctly. HOT 4
- Redesign Allocator API HOT 5
- MemoryMapRef/MemoryMapRefMut constructors HOT 1
- Alignment discrepancy between provided `Guid` class and UEFI specification HOT 1
- Memory safety issue: `TryFrom&[u8]>` impls in `device_path` have incorrect lifetime annotations HOT 2
- Evaluate, Discuss + Document role of "alloc" feature in Crate HOT 1
- terminology: treewide: Use "UEFI" rather than "EFI"
- Use with nightly uefi-std HOT 3
- Ensure lib.rs code example in uefi crate is tested HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from uefi-rs.