Should we use the original names for the types? about rust-onig HOT 3 CLOSED

I agree that the Type suffix is superfluous. I think how we that we should
stick to the original API spec and use the suffix in onig_sys. We can use
whatever names we like in the main onig crate but other people might want
to use onog_sys for direct bindings to oniguruma so we should export that
API as close to the original as Rust allows us to.

On Wed, 27 Jan 2016 at 03:14, Ivan Ivaschenko [email protected]
wrote:

I'm a little concerned that the names of some struct's in onig_sys do not
equal to the original names.

Original names:

• OnigCaseFoldType
• OnigOptionType
• OnigMetaCharTableType
• OnigEncodingType
• OnigSyntaxType

We use:

• OnigCaseFold
• OnigOptions
• OnigMetaCharTable
• OnigEncoding
• OnigSyntax

On the one hand, I do not see much sense to use Type word in the names of
structures. On the other hand, compliance with the original API may be more
important than our sense of beauty and traditions in Rust. @iwillspeak
https://github.com/iwillspeak what you think?

—
Reply to this email directly or view it on GitHub
#9.

from rust-onig.

I renamed all types to the original name.

from rust-onig.

👍

On Fri, 29 Jan 2016 at 06:34, Ivan Ivaschenko [email protected]
wrote:

I renamed all types to the original name.

—
Reply to this email directly or view it on GitHub
#9 (comment).

from rust-onig.