onig_sys doesn't build with musl about rust-onig HOT 4 CLOSED

Interesting. It looks like the oniguruma build itself is failing. I wonder if it needs to be told to cross-compile or something.

In the mean time can you install oniguruma from a package repo? It should be picked up from pkgconfig and used instead of compiling from source. That should hopefully avoid this compilation issue until I can take a deeper look at it.

from rust-onig.

I saw that there's static linking for onig-sys, so with the feature flag enabled like this:

onig = { version = "1.1.0", features = ["static-libonig"] }

And it builds inside muslrust :)! Maybe the build script should detect that situation and then default to it? I'm not sure if that's a good approach or how other sys crates handle this situation.

Looks like libz-sys detects musl: https://github.com/alexcrichton/libz-sys/blob/master/build.rs#L36

from rust-onig.

Interesting. If all that is needed is to statically link then that should be possible from the Cargo.toml. We can define a platform-specific dependency which enables the static libonig feature flag. Do you know what the target-triple is for musl?

from rust-onig.

I think something like the following should work:

[target.'cfg(target_env = "musl")'.dependencies]
onig_sys = { features = [ "static_onig"] }

from rust-onig.