The proposal to merge the two projects about rust-onig HOT 7 CLOSED

That sounds interesting. I'm glad you found my code useful.

I had a similar plan of working towards an API like the rust regex one, but with all of the Oniguruma goodness included. I'll have a look at your code and see what the best way of merging these two is.

What would you suggest?

from rust-onig.

Looks like you've got some pretty nice improvements to the rust side of things. I'm a fan of the captures object. I was just trying to work out how to implement something like that myself.

My current plan would be this:

Create a new girhub org and transfer ownership of rust-onig to it. Add your repo as a sub module and pick the changes out of it in a separate branch (subtree merge style).

I'll have a go at that this evening if it is ok with you. I notice that your repo doesn't have a license file but is MIT in the cargo file. I assume it is ok for me to treat it as MIT?

from rust-onig.

Add your repo as a sub module and pick the changes out of it in a separate branch (subtree merge style).

I'm not sure I fully understand what you want to do, but feel free to start. :) The main thing I want to avoid is duplication of capabilities in different project.

I assume it is ok for me to treat it as MIT?

Yes

from rust-onig.

Ok. I will have a go at this this evening hopefully. I've invited you to
the organisation I created so you should be able to contribute to the repo
now.

On Fri, 15 Jan 2016 at 11:51, Ivan Ivaschenko [email protected]
wrote:

Add your repo as a sub module and pick the changes out of it in a separate
branch (subtree merge style).

I'm not sure I fully understand what you want to do, but feel free to
start. :) The main thing I want to avoid is duplication of capabilities in
different project.

I assume it is ok for me to treat it as MIT?

Yes

—
Reply to this email directly or view it on GitHub
#2 (comment).

from rust-onig.

I've invited you to the organisation I created so you should be able to contribute to the repo now.

I accept your invite, but do not have write access to the repository. You have to change my permissions separately.

from rust-onig.

@iwillspeak I have created PR that makes changes to onig-sys that are necessary for unification of projects. Please review it and tell what you think. Later I will prepare a few PR's that make changes to onig crates.

from rust-onig.

All looks good. 👍 . I'll close this issue now.

from rust-onig.