Giter Club home page Giter Club logo

Comments (4)

mstrydom avatar mstrydom commented on September 25, 2024

I did just see this code: https://github.com/rust-lang/rust-bindgen/blob/main/bindgen/codegen/postprocessing/merge_extern_blocks.rs#L6 . Which looks like some merging of extern blocks happen. I am checking the version I have been using and I see I am on 0.63, so some of the local behaviour I assumed might have changed in later versions.

from rust-bindgen.

emilio avatar emilio commented on September 25, 2024

We have already a wasm_import_module_name option that adds such an attribute where you want, afaict. Extending / generalizing that seems better. Given we merge the blocks I think it'd be simpler if we didn't add extra exclusion logic or what not.

from rust-bindgen.

pvdrz avatar pvdrz commented on September 25, 2024

this could also be seen as a generalization of the custom derive callback. Maybe it would make sense to introduce a callback to annotate any rust items with custom attributes and implement the existing callbacks on top of it instead.

from rust-bindgen.

pvdrz avatar pvdrz commented on September 25, 2024

We have already a wasm_import_module_name option that adds such an attribute where you want, afaict. Extending / generalizing that seems better. Given we merge the blocks I think it'd be simpler if we didn't add extra exclusion logic or what not.

I think younger me implemented the extern blocks merge so it only happens if the extern blocks are identical, we would only need to extend this notion of identical to include attributes as well.

from rust-bindgen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.