We generate glue for C++ classes with virtual tables (for example, CustomAutoRooter in

This is basically a matter of implementing this: <div class="Box

Is this fixed via <a class="issue-link js-issue-link" data-error-text="Failed to load

Generate methods that invoke vtable pointers about rust-bindgen HOT 5 CLOSED

rust-lang commented on May 26, 2024 6

Generate methods that invoke vtable pointers

from rust-bindgen.

Comments (5)

emilio commented on May 26, 2024

Just a quick update: The vtables before were absolutely wrong anyway (didn't take into account destructors, etc.).

Also, MSVC packs virtual method overrides differently from the rest of the compilers, so this will require target-specific code (which is not a huge deal though, we already do it).

In any case, this is still a major amount of work, though certainly useful. I'll consider implementing it if there's enough need for it, though the logic is surely complex.

from rust-bindgen.

ggris commented on May 26, 2024

I was searching for information regarding this feature in bindgen. As I understand, it still has to be done as of may 2018. Is there any hope it will be considered at some point? Thanks

from rust-bindgen.

emilio commented on May 26, 2024

It's not really trivial, someone needs to go ahead and implement it properly, and add a bunch of tests. I'd be happy to mentor, though I'm not sure if I'd have the time to do it myself.

from rust-bindgen.

emilio commented on May 26, 2024

This is basically a matter of implementing this:

rust-bindgen/src/codegen/mod.rs

Lines 997 to 1018 in 91d9600

 impl<'a> CodeGenerator for Vtable<'a> { 

 type Extra = Item; 

 fn codegen<'b>( 

 &self, 

 ctx: &BindgenContext, 

 result: &mut CodegenResult<'b>, 

 item: &Item, 

 ) { 

 assert_eq!(item.id(), self.item_id); 

 debug_assert!(item.is_enabled_for_codegen(ctx)); 

 // For now, generate an empty struct, later we should generate function 

 // pointers and whatnot. 

 let name = ctx.rust_ident(&self.canonical_name(ctx)); 

 let void = helpers::ast_ty::c_void(ctx); 

 result.push(quote! { 

 #[repr(C)] 

 pub struct #name ( #void ); 

 }); 

 } 

 }

Which already has a reference to all methods and base classes. Making this work for simple casses (no base classes, no overloaded methods) should be trivial. From there we can improve.

from rust-bindgen.

pvdrz commented on May 26, 2024

Is this fixed via #2145?

from rust-bindgen.

Recommend Projects

Generate methods that invoke vtable pointers about rust-bindgen HOT 5 CLOSED

Comments (5)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	impl<'a> CodeGenerator for Vtable<'a> {
	type Extra = Item;

	fn codegen<'b>(
	&self,
	ctx: &BindgenContext,
	result: &mut CodegenResult<'b>,
	item: &Item,
	) {
	assert_eq!(item.id(), self.item_id);
	debug_assert!(item.is_enabled_for_codegen(ctx));

	// For now, generate an empty struct, later we should generate function
	// pointers and whatnot.
	let name = ctx.rust_ident(&self.canonical_name(ctx));
	let void = helpers::ast_ty::c_void(ctx);
	result.push(quote! {
	#[repr(C)]
	pub struct #name ( #void );
	});
	}
	}