Should be able to generate spidermonkey bindings without downstream patches about rust-bindgen HOT 6 CLOSED

Actually we have a flag to ignore unknown types, I don't think that's the problem.

The problem is most likely that we generate bad bindings for some kind of C++. We have an extensive set of flags to ignore types, mark them as opaque, etc. That's probably enough, except in the case we generate a bad type that is absolutely necessary to rust-mozjs.

Nick, do you know what are the blockers here? I'm happy to help :)

from rust-bindgen.

Once the current smup lands, I'll try to see if we can replace some of those ifdefs by bindgen flags.

from rust-bindgen.

Does bindgen support keeping those flags in some kind of configuration file? Something we can keep in m-c/js/src/bindgen-flags or something? I think that would make keeping C-I green easier for spidermonkey hackers who don't necessarily want to touch bindgen/rust stuff when adding new JSAPI things.

from rust-bindgen.

Nick, do you know what are the blockers here? I'm happy to help :)

Thanks! :-D

Not yet, I have a couple things to get done first (grrr NSPR) but I was going to start just running bindgen on m-c's js/ and filing bugs / submitting PRs for things that fail without downstream patches.

Wash, rinse, repeat until everything Just Works :)

from rust-bindgen.

Sounds good to me :-)
Regarding the bindgen-flags thing, I don't think something like that would be difficult to implement.

For comparison, now what we have in stylo, for example, is a python script that takes care of invoking bindgen appropriately, and it works fairly well.

from rust-bindgen.

This is fixed, isn't it?

from rust-bindgen.