Giter Club home page Giter Club logo

Comments (2)

ehuss avatar ehuss commented on July 17, 2024

It looks like this has been an issue since cargo package gained the -p flag.

I think the issue is around here. The members_with_features function has a peculiar behavior when given a spec that is not a workspace member. It will return all workspace members, because that behavior is needed for doing resolution (and handling the case where cargo build -p some_dependency is used). There probably should be some function similar to members_with_features or a separate argument that will generate an error if any of the specs does not match a workspace member.

This is sort of similar to #10677 (#10536), though publish behaves differently because it is restricted to just one package. I believe that was fixed by adding specs[0].query(member_ids)?;. members_with_features might be better suited to enforce that?

We might want to audit to see if there are any other commands that are only intended to work on workspace members have similar problems.

from cargo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.