cargo publish has bad error message when explicit `[[bench]]` isn't in `package.include` about cargo HOT 9 OPEN

I meant "strip them if they aren't included", not "unconditionally strip them". It could also likely be a user-controlled lint so people can control whether they want to error or allow it (#12235).

from cargo.

btw i have a solution in work. I am working to make it so published packages have all targets explicitly enumerated.

from cargo.

rand has package.include set:

include = ["src/", "LICENSE-*", "README.md", "CHANGELOG.md", "COPYRIGHT"]

This doesn't include benches/.

When you use auto-detected benches, cargo publish works just fine because it will auto-detect among the bundled files and be fine.

When you add [[bench]] tables, cargo knows to look for them but they were not included, and so things error.

Possible ways to improve the experience for this:

• Make the error clearer by explicitly checking whether targets were included
• Auto-strip certain types of targets, like [[bench]] and [[test]]

from cargo.

Auto-strip certain types of targets, like [[bench]] and [[test]]

I might be wrong, but doesn't crater run rely on tests being published to crates.io?

from cargo.

Isn't inclusion in the package a separate issue?

I would expect

[[bench]]
name = "uniform"
harness = false

to behave identically to

[[bench]]
name = "uniform"
path = "benches/uniform.rs"
harness = false

where benches/uniform.rs exists, given that the former is already supported by cargo bench.

from cargo.

Interesting, I hadn't realized that the presence of path makes a difference.

The reason is that without path, we have to do target auto-detection which fails. With path, we skip that and only error if the target is activated.

This makes me think we'll only be able to handle this by stripping these target as erroring would likely break some existing cases. We could still warn though and once that is user controllable, they could turn that into an error.

from cargo.

I think I'm hitting a variant of this, testing with cargo package. My Cargo.toml contains

[package]
exclude = ["benches"]
[[bench]]
# `benches/exec_compare.rs` is not meant to be run from cargo
name = "exec_compare"
bench = false

Which gives me

can't find `exec_compare` bench at `benches/exec_compare.rs` or `benches/exec_compare/main.rs`.
Please specify bench.path if you want to use a non-default path.

I can work around this by not excluding benches (but that's not the desired behavior), or by setting path="anything". The fact that even a bogus path value makes cargo happy is interesting.

from cargo.

At the time of upload，setting path but not verifying the validity of the path seems reasonable to me. But if bench = false is set, should existential checks be eliminated?

cargo book:

Setting targets to bench = false will stop them from being bencharmked by default.

I understand the implication here is that with bench = false set, Cargo will not execute benchmarks for crates with name=xx. Am I understanding this wrong?

from cargo.

@heisen-li have not checked the code but I believe this is about target path auto-discovery inconsistency when packaging, not compiling default targets.

from cargo.