Giter Club home page Giter Club logo

Comments (5)

budziq avatar budziq commented on September 24, 2024

Hi,

I am not sure what is the exact idea for this example.
Until rust-url crate officially moves to serde-1.0 servo/rust-url#327 the best that I've come up with is usage of auxiliary url_serde crate (but it would require adding it to Cargo.toml). Does it look ok? https://play.integer32.com/?gist=8199915f140db644a8bc3e480e582aea&version=undefined

If yes, I will make a PR.

cc @dtolnay

from rust-cookbook.

dtolnay avatar dtolnay commented on September 24, 2024

I would prefer to wait until we no longer need to use the roundabout approach. @SimonSapin

from rust-cookbook.

budziq avatar budziq commented on September 24, 2024

Will do. Thanks for your time :)

from rust-cookbook.

budziq avatar budziq commented on September 24, 2024

Judging from the original description I guess that the main reason for this example was the required roundabout approach.
Once servo/rust-url#327 is merged then the Url will serialize just like any other well behaved type and this example would be redundanta with https://brson.github.io/rust-cookbook/encoding.html.
So maybe just close this issue? @dtolnay

from rust-cookbook.

dtolnay avatar dtolnay commented on September 24, 2024

Yes I agree.

from rust-cookbook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.