Merge registers with the same type into an array about svd2rust HOT 3 CLOSED

When you write "contains information about PinCnf beeing an array" I assume you're talking about the dim options? Or are there other cases where this grouping should be done?

from svd2rust.

Ignore my previous comment, I wrote it before I looked into the project and how arrays are expanded.

Regarding the issue to have the RegisterBlock using arrays instead on unrolling. There are at least two ways to achieve this.

1. Instead of expanding the array, make it into a rust array. Some problems regarding this solution

   • What do we do about svd arrays not starting from 0, or skipping elements (<dimIndex> 3-6 </dimIndex>)
   • What do we do about literal indexes? (<dimIndex> A, B, C, D </dimIndex>)

2. After expanding unroll the fields into an array if they adhere to some criteria (same type, same name except ending, numbers start from 0, no holes, etc)

I guess no 2. is the way you're suggesting but isn't it better to simply not unroll when some criterions are satisfied instead of reversing the work already done?

The way that makes the most sense to me is to make an array if there are integral indexes starting from 0 and contains no holes?

Anyway, I'm in need of this feature and willing to implement it. If you think that is ok, I will need a "go on with 1" or "2 is better because of X" and I can create a PR and start the implementation.

from svd2rust.

One more remark:

Method 2 won't unroll registers if they're not grouped in SVD as they will create different register types. For an example, you can look at, https://docs.rs/s32k144/0.2.0/s32k144/can0/struct.RegisterBlock.html

So Method 1 and 2 will most likely be identical for the user.

from svd2rust.