Giter Club home page Giter Club logo

Comments (4)

eldruin avatar eldruin commented on August 16, 2024

Interesting question.
I would ask then how often should it retry. Either we create an endless loop or we define an arbitrary number which will be difficult to agree upon.
Given the general character or e-io-async, I think the caller is better positioned to put a loop on the call in this case.

from embedded-hal.

Dirbaio avatar Dirbaio commented on August 16, 2024

ErrorKind::Interrupted is annoying unix legacy-ish. I don't think anyone uses it intentionally anymore, especially now that async exists? it doesn't really exist on embedded, and i'd say it shouldn't exist.

So perhaps another option is to make embedded_io_adapters::FromStd do the retry on the write() method, so we keep Interrupted errors to the boundary of embedded-io instead of letting them in?

from embedded-hal.

rmja avatar rmja commented on August 16, 2024

That sounds like a really good idea. Should we then also remove ErrorKind::Interrupted?

from embedded-hal.

Dirbaio avatar Dirbaio commented on August 16, 2024

probably, yes...

from embedded-hal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.