Add `zig ar` and `zig ranlib` support about cargo-zigbuild HOT 11 CLOSED

@rtldg Please try v0.12.0-beta.1, if nothing goes wrong, I'll release v0.12.0 soon.

from cargo-zigbuild.

It runs into the The command line is too long. issue because of .bat/batch/cmd.exe.
I'll try to make a small example real quick to show

from cargo-zigbuild.

The limit for batch/cmd.exe being like 8192 according to google.
Also, I assume that the program calling AR will automatically use the @file-with-command-line-args.txt thing when it is above/near the Windows limit (32767?), but my current project only has like 14000~ so I'm not sure

from cargo-zigbuild.

Command: cargo +nightly zigbuild --release --target i686-pc-windows-gnu

src/main.rs

fn main() {
    println!("Hello, world!");
}

Cargo.toml

[package]
name = "testb"
version = "0.1.0"
edition = "2021"

[dependencies]
curl = { version = "0.4.33", default-features = false, features = ["rustls", "static-curl"] }

main errors:

cargo:warning=The command line is too long.
  exit code: 1

  --- stderr


  error occurred: Command "C:\\Users\\joe\\AppData\\Local\\cargo-zigbuild\\0.12.0-beta.1\\zigar.bat" "cq"
  "D:\\testb\\target\\i686-pc-windows-gnu\\release\\build\\curl-sys-86c409c566c1e694\\out\\build\\libcurl.a"
  "D:\\testb\\target\\i686-pc-windows-gnu\\release\\build\\curl-sys-86c409c566c1e694\\out\\build\\curl/lib/asyn-thread.o" 
  /* ... little over 9000 (ha) characters here (even with `\\` replaced with `/`) ... */

build log.txt

from cargo-zigbuild.

I'm not sure how to deal with this besides compiling an .exe to avoid the .bat 8192 (8191?) character limit

from cargo-zigbuild.

@rtldg Please give v0.12.0-beta.2 a try, it works on CI now.

from cargo-zigbuild.

It fails unless you have admin-privileges due to std::os::windows::fs::symlink_file it seems.
Error: A required privilege is not held by the client. (os error 1314)

I was hoping that std::fs::hard_link could replace it but that then starts to run into issues with the if target.exists() { fs::remove_file(target)?; } since it can't delete the file since it's symlinked to the running .exe

Error: failed to remove file `C:\Users\joe\AppData\Local\cargo-zigbuild\0.12.0-beta.1\ar.exe`

Caused by:
    Access is denied. (os error 5)

Might just be easiest to copy the exe instead of symlinking on Windows.

from cargo-zigbuild.

We don't really have to remove the symlink file since we already add version number in the cache directory path. Would hard_link then work for you?

from cargo-zigbuild.

That's a good point. Yeah, that'd work

from cargo-zigbuild.

@rtldg Can you try main branch?

from cargo-zigbuild.

It seems to work fine now :)

from cargo-zigbuild.