Windows username with space breaks linking about cargo-zigbuild HOT 11 CLOSED

I don't personally use Windows, so help appreciated.

from cargo-zigbuild.

The zigcc-x86_64-unknown-linux-gnu.bat that is failing contains this:

C:\Users\Marco Brieden\.cargo\bin\cargo-zigbuild.exe zig cc -- -target x86_64-linux-gnu  -g -Wl,--version-script=C:\Users\Marco Brieden\AppData\Local\cargo-zigbuild\0.16.3\fcntl.map -include C:\Users\Marco Brieden\AppData\Local\cargo-zigbuild\0.16.3\fcntl.h %*

Surrounding all paths with spaces might fix it:

"C:\Users\Marco Brieden\.cargo\bin\cargo-zigbuild.exe" zig cc -- -target x86_64-linux-gnu  -g -Wl,--version-script="C:\Users\Marco Brieden\AppData\Local\cargo-zigbuild\0.16.3\fcntl.map" -include "C:\Users\Marco Brieden\AppData\Local\cargo-zigbuild\0.16.3\fcntl.h" %*

I tried editing it, but it gets newly generated every run. Write protecting it causes zigbuild to complain and error out.

The same folder has two more files that have the same issue: "zigcxx-x86_64-unknown-linux-gnu.bat" and "zigranlib.bat".

from cargo-zigbuild.

You can change it here

And run cargo run zigbuild instead of cargo zigbuild to test it.

from cargo-zigbuild.

I think it fails to execute the .bat file in the first place, because of the path.
Any idea where that happens?

from cargo-zigbuild.

I think it's rust-lang/rust#29494, unfortunate it's out of our control because we didn't use cmd /c, something else did.

from cargo-zigbuild.

That bug has been fixed a year ago though, right?

Are you saying the batch file isn't executed from within cargo-zigbuild?
Where is it executed from then?

from cargo-zigbuild.

That bug has been fixed a year ago though, right?

They just added a new API which needs to be adopted.

Are you saying the batch file isn't executed from within cargo-zigbuild?
Where is it executed from then?

Probably cargo or cc-rs.

from cargo-zigbuild.

Actually, it's rust: https://github.com/rust-lang/rust/blob/6dc3999c2699461aa930b8c1e00f99e73dcc0174/compiler/rustc_codegen_ssa/src/back/linker.rs#L49-L58

from cargo-zigbuild.

Thanks for finding this!

from cargo-zigbuild.

I think you can workaround it by setting the CARGO_ZIGBUILD_CACHE_DIR env var to a directory that doesn't contain whitespace.

from cargo-zigbuild.

That worked, thank you very much messense!

from cargo-zigbuild.