Comments (3)
sgeisler
commented on June 30, 2024
I had a look at the code from before the introduction of u5. The same bug was present before (silently outputting vectors with elements >=32, in this case 255) and only uncoverd by the range checks of u5. I will open a fix PR soon.
from rust-bech32.
clarkmoody
commented on June 30, 2024
Well that certainly is a bug! What were you thinking of using for fuzz testing?
from rust-bech32.
sgeisler
commented on June 30, 2024
The fuzzing code can probaly be copied from rust-bitcoin with some minor changes. The main objective will be to find panic scenarios (we don't need reference data for that). I'd say a stretch goal is to link the C/C++ version from bitcoin core as a reference and check if they can cope with each other's output/produce the same output given the same input.
from rust-bech32.
Related Issues (20)
- 0.10-alpha API changes HOT 9
- bech32 string maximum length is not enforced
- Reference to `Hrp::buf` bytes HOT 2
- Checksum length HOT 3
- Stabalization - roadmap to v1.0 HOT 10
- UncheckedHrpstring should have a `data` accessor HOT 7
- Fe32::from_char_unchecked ought to be public
- InvalidWitnessVersion error display should convert fe to u8
- Buffererd encoding HOT 1
- Wrong error message
- Fuzzing not run in CI; also it doesn't work HOT 1
- `u5` does not implement `Display` HOT 1
- `convert_bits` Iterator HOT 2
- `impl<T: AsRef<[u8]>> ToBase32 for T` should be `impl<T: AsRef<[u8]> + ?Sized> ToBase32 for T`
- please add a changelog HOT 1
- github actions failure HOT 1
- Overhaul/audit Error types HOT 4
- Re-work `u5` to be a field element in GF32 HOT 2
- Support identifying potentially errorneous characters HOT 7
- Make check_hrp public HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rust-bech32.