Giter Club home page Giter Club logo

Comments (21)

MontejoJorge avatar MontejoJorge commented on June 11, 2024

Hey, im working on this, could you assign it to me? Thx!

from runtipi.

steveiliop56 avatar steveiliop56 commented on June 11, 2024

Hello, of course here you go!

from runtipi.

MontejoJorge avatar MontejoJorge commented on June 11, 2024

How do you think the users should be able to edit/delete the existent links? With an icon for each link (like the update icon for each app tile), maybe create a tab in the settings? Any suggestions?

from runtipi.

steveiliop56 avatar steveiliop56 commented on June 11, 2024

Hmm I will create some figma designs and share them with you. I believe it should be a setting to enable and add an extra section in the dashboard. @meienberger what do you think?

from runtipi.

steveiliop56 avatar steveiliop56 commented on June 11, 2024

@meienberger @MontejoJorge I think we should use something like this https://www.figma.com/file/xs9xSW6SX8KnvLbIFVycXa/Tipi-Custom-Links?type=design&node-id=0%3A1&mode=design&t=vyexbgq1vlkIBbN6-1

from runtipi.

MontejoJorge avatar MontejoJorge commented on June 11, 2024

I was doing it inside the app section, like each link will look like just another app, but makes mor sense to put it in the dashboard. But how the users will be able tu edit a link or delete it?

from runtipi.

steveiliop56 avatar steveiliop56 commented on June 11, 2024

I think you should just replicate the casa os thing. If you want I can redesign it too

from runtipi.

MontejoJorge avatar MontejoJorge commented on June 11, 2024

Okay, I will take a look

from runtipi.

meienberger avatar meienberger commented on June 11, 2024

Not sure I really like this feature somehow. It's participating to bloatware and adds stuff in the UI making it more complex. If you can find a way to hide it I would appreciate

from runtipi.

meienberger avatar meienberger commented on June 11, 2024

How do you think the users should be able to edit/delete the existent links? With an icon for each link (like the update icon for each app tile), maybe create a tab in the settings? Any suggestions?

I think we have to be careful to not add more buttons and clicks in the dashboard. Something like a context menu would be just perfect to not expose this flow by default to new users

from runtipi.

steveiliop56 avatar steveiliop56 commented on June 11, 2024

Hmm but where should we add the custom links? My idea is that if they go to the apps section to be harder to use due to some users having a lot of apps so that's why I though of the dashboard. Also this should be a toggle switch in settings.

from runtipi.

meienberger avatar meienberger commented on June 11, 2024

Since we have the guest dashboard it would make sense to have it in my apps. Also why do you consider it should be a toggle in settings? It’s nothing you need to activate. Either you add a link or not. We could also rethink how the dashboard works and make this the public dashboard

from runtipi.

steveiliop56 avatar steveiliop56 commented on June 11, 2024

I am not done but because I don't have much time left here is the basic idea. https://www.figma.com/file/xs9xSW6SX8KnvLbIFVycXa/Tipi-Custom-Links?type=design&node-id=0%3A1&mode=design&t=xEHyv3n9ALdoDdk5-1

from runtipi.

MontejoJorge avatar MontejoJorge commented on June 11, 2024

I was doing it like this:
image
image

But i liked the idea of an 'app' tile with a '+ add custom link'

from runtipi.

steveiliop56 avatar steveiliop56 commented on June 11, 2024

Well since you already made it we keep it like that. If you could just fix this
image
make the font bigger and use a title like "Add custom link". Also make sure that this looks ok in dark mode too.

from runtipi.

steveiliop56 avatar steveiliop56 commented on June 11, 2024

Also when are you going to open a pr? I will be happy to test/review.

from runtipi.

MontejoJorge avatar MontejoJorge commented on June 11, 2024

Also when are you going to open a pr? I will be happy to test/review.

Soon, I have to do the edit/delete feature yet

from runtipi.

steveiliop56 avatar steveiliop56 commented on June 11, 2024

Also when are you going to open a pr? I will be happy to test/review.

Soon, I have to do the edit/delete feature yet

ok ok

from runtipi.

meienberger avatar meienberger commented on June 11, 2024

Cool @MontejoJorge maybe instead of the big green button you could add a tile like you said always at the end of the list

from runtipi.

steveiliop56 avatar steveiliop56 commented on June 11, 2024

I think the button is a nice idea I don't know about the green color tho. Alternatively I would prefer this
image
because in the future we could add more stuff and make it cooler

from runtipi.

MontejoJorge avatar MontejoJorge commented on June 11, 2024

Resolved on #1206

from runtipi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.