Comments (6)
How about this?
$ finch version
Client:
Version: v0.1.0
OS/Arch: linux/amd64
Git commit: c00780a1f5b905b09812722459c54936c9e070e6
nerdctl:
Version: v1.0.0
GitCommit: <commit>
buildctl:
Version: v0.10.5
GitCommit: bc26045116045516ff2427201abd299043eaf8f7
Server:
containerd:
Version: v1.6.8
GitCommit: 9cd3357b7fd7218e4aec3eae239db1f68a5a6ec6
runc:
Version: 1.1.4
GitCommit: v1.1.4-0-g5fd4c4d1
I feel adding a separated Finch version block makes the output format of "finch version" too special. From Finch users' perspective, Finch itself is the client itself so Finch version is just the client version. Nerdctl can be added as part of Client dependency.
from finch.
I don't see a strong reason adding virtualization layer dependency version, and not adding virtualization layer seems to make the version output easier to be consistent across all the platforms. Maybe we can exclude virtualization layer dependency version for now. We can add it later if people come up with a good justification.
from finch.
I agree that it's no big deal to add the Lima version on its own. But following that line of reasoning, why shouldn't we also add the QEMU version, the Fedora version, etc?
In my opinion, it'd be better to keep the output of this command shorter to make it easier to parse at a glance. In order to do that, we'd need to draw the line somewhere, and I think this line makes the most sense.
It might be helpful in some scenarios , for example, issue investigation or any unsupported scenarios.
I believe the Lima version should map 1:1 with a Finch version, so we should be able to determine the Lima version from the Finch version when we're investigating.
from finch.
should we also add lima version
in the Client
?
from finch.
Yeah, I think the nerdctl/buildkit/containerd/runc version is useful to our users because there are user-facing features that might be added in a new version of each of those. Iโd argue that Lima features arenโt really user-facing for users of Finch because the Finch VM is mostly transparent.
from finch.
What are cons of displaying lima version? It might be helpful in some scenarios , for example, issue investigation or any unsupported scenarios. Can't we just call the lima cmd and display the version?
from finch.
Related Issues (20)
- Support BYO credential helpers
- Build fails specifying --platform linux/amd64 sometimes "failed to compute cache key", "failed to create snapshot" HOT 2
- Failed to install on macos-14 github actions runner HOT 2
- docker manifest equivalent HOT 2
- Support --build-context for buildkit HOT 1
- 50GB carved out disk file is surprising as a Docker Desktop user HOT 5
- Unable to use the "--env" option on finch container run HOT 3
- Clock drifts in 1.1.2 HOT 3
- Unable to run /usr/bin/sudo due to volumes/main partition mounted with nosuid HOT 1
- Change ~/.finch/config.json to support compatibility with CDK `DockerImageAsset` HOT 1
- Speed up "sending tarball" step for PythonFunction CDK Construct HOT 2
- SHA256 Mismatch Error When Installing Finch v1.1.3 via Homebrew HOT 5
- Unable to use the "--env-file" option on "finch compose up" command
- Support bundle fails to be created on Windows
- Add features not to forget to execute `finch gen-docs generate -p cmd/finch/` HOT 3
- Unable to start VM after closing command prompt on Windows
- Where is the finch website? HOT 1
- Support AWS CodeBuild local builds with Finch HOT 3
- Enable finch-core local builds
- Support intellij dev containers
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from finch.