Comments (3)
This is due to your environment variable named SECRET. A quick fix would be to rename it to something else. That being said, I do plan on adding a top level job secrets
construct to house all secrets, so I never have to redact anything within the job but only that section.
from tork.
My intention is to redact everything. I have the secret pattern config like this:
[middleware.job.redact]
enabled = true
patterns = ["*"]
But that is not relevant to the point I'm making. I'm just proposing that maybe don't redact the variables whose value is inherited from inputs, because it's not the actual content anyway.
from tork.
Parsing the value has too many edge cases. Example:
{{inputs.not_a_secret}}/actual_secret
So if I don't redact this it will have the secret in the clear.
That's why I'm thinking of adding a new secrets construct that will be more explicit.
from tork.
Related Issues (20)
- Add support for release-drafter HOT 1
- No env vars in pre/post tasks HOT 1
- priority of a job HOT 5
- Docker compose HOT 1
- [feature] Tork worker default folder HOT 2
- [feature] Option to stop/continue current Job with parallel tasks HOT 6
- Prune old nodes HOT 3
- [bug] entrypoint can't find script inside HOT 1
- RUNNING state change not shown on middleware HOT 1
- Pre/Post task evaluate issue when used with job middleware HOT 3
- Feature Request: support allowing custom headers in webhooks HOT 1
- feature request: Download all logs for a job HOT 6
- Option to delete old jobs HOT 2
- Task container port mapping HOT 11
- Like how simple this application is. How to contribute? HOT 3
- Support of recurring jobs
- Passing in JSON through task output HOT 1
- request: make get log max page size configurable HOT 2
- request: disable logging HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tork.