Comments (3)
@ghislainfourny . This issue was created as per your request to refactor iterator materialization in the top level iterator class. The comment above gives full details. In the current implementation, this function is implemented in RuntimeIterator:
What kind of a change did you have in mind? Could you please elaborate.
from rumble.
I think what I had in mind was adding a public method to the Iterator class that materializes an iterator:
List materialize(DynamicContext context)
This would simply make this functionality official and clean.
This function should ideally return an error if the iterator is already open (for this we may need to add an isOpen() method and a private field that keeps track of the "openness" of the iterator).
from rumble.
I think this is all addressed with various functions materializeAtMostOneItem, materializeOneItemOrNull, etc.
from rumble.
Related Issues (20)
- Out of memory error when summing large sequence HOT 5
- Offer: Install-Script for Linux HOT 4
- optimization issue of count after group by HOT 13
- Non-local variables from let clauses are missing in subsequent for clauses HOT 3
- Join detected by where clauses incorrectly HOT 3
- Read context item from standard input
- Behavior of RumbleDB shell when users press Ctrl+C
- Accumulate prologs in Jupyter notebook
- Fall back to CLI parameters in server mode when unspecified as URL query parameters
- Dependency AVG is not supported yet.
- HTTP Parameters HOT 1
- Running Rumble with Docker on M1 doesn't seem to work HOT 2
- Whitespace in working directory causes crash HOT 3
- Overoptimization of variable dependencies HOT 1
- Dependency org.yaml:snakeyaml, leading to CVE problem
- Use static types instead of context-generated types for native SQL queries
- Memory Issue HOT 1
- Problem on Windows reading multiple files at once.
- materialization cap question
- "An error has occured" selection clause
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rumble.