Giter Club home page Giter Club logo

Comments (3)

CanBerker avatar CanBerker commented on May 23, 2024

@ghislainfourny . This issue was created as per your request to refactor iterator materialization in the top level iterator class. The comment above gives full details. In the current implementation, this function is implemented in RuntimeIterator:

https://github.com/Sparksoniq/sparksoniq/blob/12210e01129cfd6e3fad03abd71f5c18e11ac1b9/src/main/java/sparksoniq/jsoniq/runtime/iterator/RuntimeIterator.java#L117

What kind of a change did you have in mind? Could you please elaborate.

from rumble.

ghislainfourny avatar ghislainfourny commented on May 23, 2024

I think what I had in mind was adding a public method to the Iterator class that materializes an iterator:

List materialize(DynamicContext context)

This would simply make this functionality official and clean.

This function should ideally return an error if the iterator is already open (for this we may need to add an isOpen() method and a private field that keeps track of the "openness" of the iterator).

from rumble.

ghislainfourny avatar ghislainfourny commented on May 23, 2024

I think this is all addressed with various functions materializeAtMostOneItem, materializeOneItemOrNull, etc.

from rumble.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.