Macaroon not 32 bytes about homeserver HOT 3 CLOSED

Thanks for the report! I'll take a look at this, but it might be a few days, as I'll be out of town on vacation through next week.

from homeserver.

The issue here is that base64.NewEncoder writes to the provided buffer in blocks of 4 bytes, and must be manually closed to flush any remaining bytes of less than a block of 4, so you're ending up with only a 30 byte value.

Looks like you can fix it by either calling Close on the encoder, or by using EncodeToString instead:

encoded := base64.StdEncoding.EncodeToString(b)
fmt.Println(encoded)

I think it'd be useful for Ruma's CLI to have a command to easily generate a value suitable for use as the macaroon secret key, so I'm going to leave this issue open to remind me to do that.

from homeserver.

My bad, I should really read the docs more thoroughly. Still bothers me that defer won't work in this context.

Obsoleted by #267dfd9, but here is my patched code:

package main

import (
    "bytes"
    "crypto/rand"
    "encoding/base64"
    "fmt"
    "log"
)

// Macaroon type
type Macaroon []byte

// NewMacaroon returns a random Macaroon
func NewMacaroon() ([]byte, error) {
    b := make([]byte, 32)
    _, err := rand.Read(b)
    if err != nil {
        return nil, err
    }
    buf := bytes.Buffer{}
    w := base64.NewEncoder(base64.StdEncoding, &buf)
    _, err = w.Write(b)
    if err != nil {
        return nil, err
    }
    w.Close()
    return buf.Bytes(), nil
}

func main() {
    m, err := NewMacaroon()
    if err != nil {
        log.Fatal(err)
    }
    fmt.Println(string(m))
}

from homeserver.