[Investigation] Look into removing Cocoon about human-essentials HOT 4 CLOSED

That gem doesn't seem to be super popular (only 115 stars). With Rails I've found that jumping towards using gems for things can bite us in the long run as many of them stop being maintained, or don't quite do what we wanted them to. It shouldn't be too much code to roll our own, especially if we can use Stimulus for it.

It looks like there are around 10 places in the app total that use it, but many of those are funneled through one helper method, add_line_item_button.

from human-essentials.

Hi @cielf, do you know this gem https://github.com/arielj/vanilla-nested? it is well-maintained and also doesn't depend on jQuery. what do you think about it? do you know how many places we need to update?

from human-essentials.

Is removing cocoon still on the Todo list?

I was thinking of tackling this. I was thinking that we could reuse request behavior and replace:

<div class="col-xs-12">
  <%= add_line_item_button f, "#transfer_line_items" %>
</div>

with

<%= add_item_button('Add Another Item') do %>
  <%= render 'item_request', form: form, object: @partner_request.item_requests.build %>
<% end %>

Edit: this would likely require making the add button method and the stimulus controller a bit more generic but the changes seem pretty reasonable to do.

from human-essentials.

Sure, this would be great. The fewer dependencies, the better.

from human-essentials.