Giter Club home page Giter Club logo

Comments (5)

sarvaiyanidhi avatar sarvaiyanidhi commented on June 20, 2024 1

Thank you for the clarification. Will look into this after completing other tickets. Thanks

from casa.

sarvaiyanidhi avatar sarvaiyanidhi commented on June 20, 2024

While evaluating implementation for current code to add test for issue #5513 I found that in currently implemented code there is issue in implementation as on click of volunteer name in supervisor learning page it is passing learning_hour.user_id and redirecting it to learning_hours controller show page which is trying to find learning hour using user id.

As per requirement mentioned in issue #5474 , we need to show all learning hours of Volunteer and not specific learning hour as implemented.

I also wanted to check instead of redirecting to Volunteer's learning hour page on click of Volunteer name, should we show for Supervisor and Casa Admin learning hours for Volunteer on its learning hour page itself as we do for Other duties so that view is similar across all pages.

other_duties

from casa.

bcastillo32 avatar bcastillo32 commented on June 20, 2024

While evaluating implementation for current code to add test for issue #5513 I found that in currently implemented code there is issue in implementation as on click of volunteer name in supervisor learning page it is passing learning_hour.user_id and redirecting it to learning_hours controller show page which is trying to find learning hour using user id.

As per requirement mentioned in issue #5474 , we need to show all learning hours of Volunteer and not specific learning hour as implemented.

I also wanted to check instead of redirecting to Volunteer's learning hour page on click of Volunteer name, should we show for Supervisor and Casa Admin learning hours for Volunteer on its learning hour page itself as we do for Other duties so that view is similar across all pages.

other_duties

Hi @sarvaiyanidhi thank you for bringing this to our attention. Yes, you are correct - we want the supervisors/admins to be taken to what the volunteers see on their learning hours page. Those details are important to the supervisors/admins. For Other duties - we can do the same where we take the supervisor/admin to what the volunteer sees. But if you like we can handle it on a separate ticket. Let me know what you prefer.

from casa.

jp524 avatar jp524 commented on June 20, 2024

Hi there, I am working on #5550 which is related. Just to let you know that my PR should also resolve this issue.

from casa.

sarvaiyanidhi avatar sarvaiyanidhi commented on June 20, 2024

Thank you Jade for the heads up.

from casa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.