Comments (5)
Thank you for the clarification. Will look into this after completing other tickets. Thanks
from casa.
While evaluating implementation for current code to add test for issue #5513 I found that in currently implemented code there is issue in implementation as on click of volunteer name in supervisor learning page it is passing learning_hour.user_id and redirecting it to learning_hours controller show page which is trying to find learning hour using user id.
As per requirement mentioned in issue #5474 , we need to show all learning hours of Volunteer and not specific learning hour as implemented.
I also wanted to check instead of redirecting to Volunteer's learning hour page on click of Volunteer name, should we show for Supervisor and Casa Admin learning hours for Volunteer on its learning hour page itself as we do for Other duties so that view is similar across all pages.
from casa.
While evaluating implementation for current code to add test for issue #5513 I found that in currently implemented code there is issue in implementation as on click of volunteer name in supervisor learning page it is passing learning_hour.user_id and redirecting it to learning_hours controller show page which is trying to find learning hour using user id.
As per requirement mentioned in issue #5474 , we need to show all learning hours of Volunteer and not specific learning hour as implemented.
I also wanted to check instead of redirecting to Volunteer's learning hour page on click of Volunteer name, should we show for Supervisor and Casa Admin learning hours for Volunteer on its learning hour page itself as we do for Other duties so that view is similar across all pages.
Hi @sarvaiyanidhi thank you for bringing this to our attention. Yes, you are correct - we want the supervisors/admins to be taken to what the volunteers see on their learning hours page. Those details are important to the supervisors/admins. For Other duties - we can do the same where we take the supervisor/admin to what the volunteer sees. But if you like we can handle it on a separate ticket. Let me know what you prefer.
from casa.
Hi there, I am working on #5550 which is related. Just to let you know that my PR should also resolve this issue.
from casa.
Thank you Jade for the heads up.
from casa.
Related Issues (20)
- Fix "Manage Volunteers" Styling on `/volunteers` page HOT 1
- Disable expenses page when orgs have no expenses HOT 3
- Add "Enable Other Duties" as Organization Feature flag to Edit Organization HOT 2
- Improve case selection UX on `/casa_cases` page for admins with many cases HOT 1
- Uncap submissions for Additional Expenses and improve UX
- Improve datatable display of volunteers on `/supervisors` page
- Improve discoverabilty for creating and editting Court Report Topics
- Case Contact Form Update: Change Section "1. Select the relevant cases" picker to Dropdown style like in Section 2. Select All Contact Types
- Add Back and Forth Buttons to Case Contact Form HOT 3
- add the ability for organization to create and edit placement types within their org
- add seed data for placements HOT 2
- add creating, editing and displaying placements to casa case show page
- create standard court orders on a per organization basis
- ☂️ Standard Court Orders HOT 2
- Add Court Report Topics Answers to Case Contact Cards
- add court report topic answers to case contact export HOT 3
- Add court report topic answers to weekly emails
- export all data generates a file when the filter modal is close even if close with X rather than generate HOT 5
- Improve banner expiration validations and form HOT 1
- refactor volunteer case contact form to use new submit button component HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from casa.