'context' undefined in rescue_from in 2.1.0 about grape HOT 9 CLOSED

oh, I didn't notice it was loaded there, sorry for the wrong accusation ^^" I'm glad the root cause was discovered 👍

from grape.

Thanks for fixing this @ericproulx.

from grape.

I believe it's because of #2363 the Grape::Middleware::Helpers module is no longer eager loaded. Adding helpers Grape::Middleware::Helpers fixes the issue.

from grape.

@krismichalski your close but the helper is included and loaded in Grape::Middleware::Base and Grape::Middleware::Auth::Base

Nonetheless, I think I know what's the issue, since #2377, rescue_from are endpoint.instance_exec instead of instance_exec. Since the endpoint doesn't have the helper included, adding helpers Grape::Middleware::Helpers makes it work.

from grape.

@krismichalski Looks like this isn't a bug? Can you please take a look at https://github.com/ruby-grape/grape/blob/master/UPGRADING.md and make sure it accurately describes this situation for the next person?

from grape.

@krismichalski Looks like this isn't a bug? Can you please take a look at https://github.com/ruby-grape/grape/blob/master/UPGRADING.md and make sure it accurately describes this situation for the next person?

For me, it feels like a bug since we narrowed the context of all rescue_from to the endpoint. I've made a fix which is very simple

from grape.

@mscrivo could you checkout my branch and see if it works ?

from grape.

@mscrivo @krismichalski since the rescue_from's block has the context of the endpoint, you should be able to just call env directly instead of context.env.

@dblock I think we should add it back like in my PR and add deprecation on future releases.

from grape.

@ericproulx your branch seems to work great, our tests are passing

from grape.