Causes reload during first data load (and incompatible with Anvil Crushing Recipes) about rug HOT 4 CLOSED

Thanks for the hint, the ResourceManagerHelper.registerBuiltinResourcePack method should I think do what I want, but I don't have the necessary internet connection to test right now

from rug.

Actually after having a closer look now, I don't think that method works. It requires the datapack to be in the mod jar file, but the whole reason why I manually copy the files into the datapack directory is that I need the pack to be dynamic, depending on what rules are set the contents of that pack vary.

As previously discussed in #17 (comment), I am also pretty much unable to create the datapack files before the default first load starts, because carpet only parses the rule config after that.

If you have another suggestion for a potential solution or I simply misunderstood the registerBuiltinResourcePack method, please tell me. You seem a lot more experienced with fabric mod development than I am. Otherwise I sadly might have to close this as wontfix...

from rug.

My recommendation would be: for each carpet rule that controls a datapack, remove it, and replace it with a builtin datapack.

The only difference for users would be that they enable/disable them with /datapack enable/disable <data pack name> instead of /carpet <carpet rule name> true/false.

from rug.

That won't work with rules like unpackableIce however, as they can be customized with a user specified integer value. Also I like the way these rules are integrated with the others, so users don't have to think about them being any different.

So, as the hard conflict between our mods seems to have been resolved on your side, I will close this now.

from rug.