Giter Club home page Giter Club logo

Comments (15)

WtfJoke avatar WtfJoke commented on June 3, 2024

Yup, that would make sense to have that as an additional criteria.
What I wonder is, how do you know from which component the changeset is?

from rtc2git.

jacobilsoe avatar jacobilsoe commented on June 3, 2024

I guess it could be deduced from the history files - in those cases where they are supplied.

from rtc2git.

WtfJoke avatar WtfJoke commented on June 3, 2024

No, because they history files only contain the uuids. I think to extend them just for this issue would be a little bit too much in my opinion. Maybe there is another way to determine the component of a changeset.

from rtc2git.

jacobilsoe avatar jacobilsoe commented on June 3, 2024

I was thinking of using the name of the history file since this name is made up of the stream name and component name.

from rtc2git.

WtfJoke avatar WtfJoke commented on June 3, 2024

Ah 😅 Yeah I guess that would be possible'^^

from rtc2git.

ohumbel avatar ohumbel commented on June 3, 2024

I already started looking into this...

from rtc2git.

ohumbel avatar ohumbel commented on June 3, 2024

You can track what I am doing in this branch: https://github.com/ohumbel/rtc2git/tree/conflictresolution

from rtc2git.

ohumbel avatar ohumbel commented on June 3, 2024

Now after all this merging, I should be able to concentrate on this issue again.
However, I am in a different project for the next 2 days.

from rtc2git.

jacobilsoe avatar jacobilsoe commented on June 3, 2024

Let me know if I can help with anything.

from rtc2git.

ohumbel avatar ohumbel commented on June 3, 2024

Uh oh an Xcode update on my mac unset my --local user.name and user.email.
But my .ssh key of course is still valid.
Please apologise for 2 commits with 'anyAuthor'.
I think it is not worth rewriting the whole history because of that (see https://help.github.com/articles/changing-author-info/)

from rtc2git.

ohumbel avatar ohumbel commented on June 3, 2024

@jacobilsoe I would be very glad if you could verify your use case(s) with my 'conflictresolution' branch (https://github.com/ohumbel/rtc2git/tree/conflictresolution). I am pretty confident that it will work, but have no live data (yet) to test it myself.
If you are satisfied with the result, we can create a pull request and merge it into develop.

from rtc2git.

WtfJoke avatar WtfJoke commented on June 3, 2024

Please apologise for 2 commits with 'anyAuthor'.
I think it is not worth rewriting the whole history because of that (see https://help.github.com/articles/changing-author-info/)

No problem^^ Happens fast.

from rtc2git.

jacobilsoe avatar jacobilsoe commented on June 3, 2024

@ohumbel I tried out your fix in the 'conflictresolution' branch. It works just as it should. Thanks! I also looked through the code and it looks good. So I think you can create a pull request.

from rtc2git.

ohumbel avatar ohumbel commented on June 3, 2024

@jacobilsoe A thousand thanks for verifying 😳

from rtc2git.

ohumbel avatar ohumbel commented on June 3, 2024

The pull request triggers a travis-ci build 🎆
But the usage of enum is only supported from python 3.4 on (see https://docs.python.org/3/library/enum.html). Therefore the python 3.3 build fails. I did not know that, and enum came in handy.

There are 2 ways to fix that:

  • disable the 3.3 build
  • do not use enum

@WtfJoke Manuel what do you propose?

IMHO it is acceptable to require a quite recent version of python.

from rtc2git.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.