Solr URI is not sanitized in RSolr::Error::Http messages about rsolr HOT 5 CLOSED

Hey @jcoyne, thanks for the answer!
In this case to achieve some more security I would go with just a hostname, port and path, it should be quite enough to get info about any network issue.
Unfortunately there's no built in method to clear the uri for printing, so what about just pretty straightforward "patch" with concatenating these uri parts?
Something like this:

def clean_uri(uri)
  "#{uri.scheme}://#{uri.user && uri.password ? "REDACTED:REDACTED@" : ''}#{uri.hostname}#{uri.port ? ":#{uri.port}" : ''}#{uri.path}#{uri.query ? "?#{uri.query}" : ''}"
end

uri = URI.parse("http://username:[email protected]:8983/solr/admin/update?wt=json&q=test")
clean_uri(uri) # => "http://REDACTED:[email protected]:8983/solr/admin/update?wt=json&q=test"

uri = URI.parse("http://hostname.local:8983/solr/admin/update")
clean_uri(uri) # => "http://hostname.local:8983/solr/admin/update"

A bit ugly I know, but currently it's seriously compromises Solr credentials for a bunch of people when throws exception into Rollbar for example

from rsolr.

Great, I'll work on putting together a PR.

from rsolr.

@esergion how would you propose something like this is fixed?

It looks like the problem is here:

from rsolr.

Hello! I am running into this problem. Is there any issue with the approach described by @esergion or is it just a matter of submitting an PR? Thanks!

from rsolr.

I think we just need someone who wants to do that work.

from rsolr.