Giter Club home page Giter Club logo

Comments (4)

davidmascharka avatar davidmascharka commented on May 27, 2024 1

Yep, everything else looked good to me.

from learning_python.

davidmascharka avatar davidmascharka commented on May 27, 2024

Few comments (again, no line numbers because diffs on json are gross):

  • "Indexing into and slicing along the dimensions of an array is known as -> "are known as"

  • "provided a comprehensive rundown the use of" -> "rundown on the use of"

  • "Using a Tuple as a N-dimensional Index" -> "as an N-dimensional index"

  • "every time we index into a an array" -> get rid of the extra 'a'

  • I.e. x[i, j, k] is equivalent" -> That is, x[i, j, k] is" because capitalized I is weird and an abbreviation at the beginning of a sentence is odd.

  • "Given a N-dimensional array, x" -> an N-dimensional

Reading comprehension: Ellipsis

I don't know what this question is asking. You "axis entry-0 of axis-0, the last entry of axis-$N-1$, slicing along all intermediate dimensions" but I have no idea what that means. I assume that's access entry-0, but I'm not sure where the last entry comes in.

  • "which of the following indexing schemes perform basic indexing." -> make it a question

  • There are two hanging Jupyter code cells that I assume were for scratch. Delete those.

  • "creates a distinct array, and assigns the variable subarray to that new array." -> assigns that new array to the variable subarray.

  • "Which of the following create views x? That is" -> "create views of x"

  • "versus performing operations that produces an array" -> produce an array

  • "Assigning a to a new array simply changes..." -> "Assigning a new array to a simply changes"

  • "Assign row-0, colum-0 with the value" -> "Assign row-0, column-0 the value" (get rid of 'with')

  • Same for row-0, column-2 below that

  • "Recall from our discussion of basic mathematic expressions in Python" -> "mathematical expressions"

  • I.e. the assignment expression x = x + 5 -> For example, the assignment...

  • "arrays update the underyling data reference by that" -> "arrays update the underlying data referenced by that" (spell underlying correctly and change reference to referenced)

  • "Benefits and Risks to Autgmenting Data" -> Benefits and Risks of

  • "This will affect any arras that are views" -> arrays that are views

from learning_python.

rsokl avatar rsokl commented on May 27, 2024

@davidmascharka this is the entire review, right?

from learning_python.

rsokl avatar rsokl commented on May 27, 2024

These were awesome. Super easy to find/replace all the fixes!

from learning_python.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.