Giter Club home page Giter Club logo

Comments (4)

NiteshKant avatar NiteshKant commented on June 15, 2024

I had a chat on this with @tmontgomery and the opinion at that point was that it can be an optional (but a prescribed best practice) application concern and not a part of the protocol.

For the request type, I think it should be a REQUEST_SUBSCRIPTION request so that it can be subject to flow control semantics as opposed to every heartbeat being a new request. Also, the keepalive should be acknowledged by the peer to handle half-close TCP connections. So, it will be a ping-pong as opposed to a ping :)

from rsocket.

tmontgomery avatar tmontgomery commented on June 15, 2024

This falls into the area of handling the unexpected. Liveness for a duplex channel should be dual, but it should be 1 ends responsibility to initiate. If the protocol needs to provide this to the applications, then it should be baked in and should handle half-open sockets as well as any lack of response.

SUBSCRIPTION semantics aren't quite right. It does inform one side, but not the other. REQUEST_RESPONSE is closer, but still not quite right for all cases.

Application keepalive covers a lot of ground.

  1. loss of continuity of physical network
  2. loss of continuity of transport
  3. loss of continuity of ReactiveSocket layer on 1 side
  4. loss of continuity of application layer on 1 side

If this should be a protocol concern, we can add a PING frame much like WebSockets has. Optionally used.

from rsocket.

tmontgomery avatar tmontgomery commented on June 15, 2024

KEEPALIVE frame is being added that this can utilize.

from rsocket.

stevegury avatar stevegury commented on June 15, 2024

Closing this issue:
KEEPALIVE has been added, and applicative ping should be a normal request/response (in order to properly measure application queuing time).

from rsocket.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.