Giter Club home page Giter Club logo

Comments (6)

tmontgomery avatar tmontgomery commented on June 15, 2024

SETUP could use a value of 0 for Keepalive interval to signal that it won't send KEEPALIVEs. That could cause a server to send back a SETUP_ERROR if it must support it. Thus the server can reject.

from rsocket.

NiteshKant avatar NiteshKant commented on June 15, 2024

@tmontgomery I agree that it is possible for client-server to agree/disagree on keep-alive in the current state of the protocol. I am suggesting that we make keep-alive turned on by default in the spec so if the client/server do not disable it, it will be on. Disabling will be a conscious choice with the knowledge of the edge cases that may arise by turning it off. Currently, the spec seem to suggest that keep-alive is opt-in and not opt-out or at least such a suggestion is absent.

from rsocket.

tmontgomery avatar tmontgomery commented on June 15, 2024

Hmm. This might come down to wording. Do you have some wording in mind to clarify it?

from rsocket.

NiteshKant avatar NiteshKant commented on June 15, 2024

Let me send a PR for this.

from rsocket.

tmontgomery avatar tmontgomery commented on June 15, 2024

Updated KEEPALIVE wording. Take a look and see if this works.

from rsocket.

benjchristensen avatar benjchristensen commented on June 15, 2024

Updated the wording in the spec.

from rsocket.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.