Should Lease contains a deadline? about rsocket HOT 2 CLOSED

Absolutely it is a tricky decision to make!

My reservations around using deadline are the following:

• As you specified, using time means that we need to take care of propagation delays.
• The client code becomes complex as it has to be considerate of time before making a request. So, it will manifest in two ways:
  • Check for current time and hence deadline before each request.
  • Or have a scheduled timer for each connection from the client that resets the request quota for that duration.

Both of the above sounds too heavy a burden to force from the protocol IMO.

I do agree that the lease expiry is a nice side-effect for an overloaded server. An argument against that could be that for a well behaved client and properly implemented flow control from the server, hitting the wall (overloaded) would mean that the server over-subscribed for requests.

Overall, I do not have a concrete reason for either ways but using time does make me nervous!

from rsocket.

Just for the record, we ended up choosing to keep a TTL in the lease message.
It has the nice property of automatically applying backpressure when a server is overloaded (it doesn't need to do any extra work to shed load away)

from rsocket.