Should has_changed/initial_value work with on_commit hooks? about django-lifecycle HOT 5 CLOSED

I found that moving the self._initial_state = self._snapshot_state() at the end of the save method to a on commit callback works for hooks with on_commit=True and on_commit=False.

I can work on a PR for this if you think it is the right path.

from django-lifecycle.

Hi! Just faced the same error today. Then came in here and saw that this was the last open issue 😂

Although I don't understand what you're saying here @alb3rto269 🤔

moving the self._initial_state = self._snapshot_state() at the end of the save method works

This line is already at the end of the save method.
Maybe this could be an approach:

    def run_save(self, *args, **kwargs):
        # Run before_* hooks
        super().save(*args, **kwargs)
        # Run after_* hooks
        
    def save(self, *args, **kwargs):
        with transaction.atomic():
            self.run_save(*args, **kwargs)

        self._initial_state = self._snapshot_state()

from django-lifecycle.

@amatmv My bad. I just fixed my comment.

I meant moving the last line of the save method to a on-commit callback.

Notice that according Django's docs, on-commit callbacks are executed in the order they are registered. Therefore, we can ensure that this new "reset_state" callback will be executed after any other callback registered by the AFTER_* hooks.

Something like this:

def reset_state(self):
    self._initial_state = self._snapshot_state()

def save(self, *args, *kwargs):
    # run before_* hooks
    save(*args, **kwargs)
    # run after_* hooks
    transaction.on_commit(self.reset_state)

from django-lifecycle.

Yes! It seems also a good approach. @alb3rto269
I'll be happy to take a look if you make a PR for this.

from django-lifecycle.

I created a PR for this issue.

from django-lifecycle.