Please add [CanBeNull] attribute to some methods about codejam HOT 5 CLOSED

[NotNull] here means that the dictionary itself cannot be null. Nothing to fix there.

from codejam.

@Lexey, OP is talking about marking the return value with [CanBeNull]. it looks reasonable for me.

@MozgC, will do. BTW doing a PR would work too:)

from codejam.

@MozgC I've marked only overloads that have no selector or explicit default value arg. If this is not what you want - let me know:)

from codejam.

var dict = new Dictionary<int, List<int>>();
var nullList = dict.GetValueOrDefault(777); // nullList is now null
var x = nullList.FirstOrDefault(); // An exception will occur here. But ReSharper doesn't warn about the exception. But if you add [CanBeNull] attribute to the whole GetValueOrDefault() method, then ReSharper will know that the method can return null and will warn the user.

from codejam.

@ig-sinicyn, awesome, thank you!

from codejam.